From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 23 Sep 2010 11:32:58 +0200 Subject: [U-Boot] [PATCH 1/2] [NEXT] orion5x: fix relocation-incompatible code In-Reply-To: References: <1285097735-813-1-git-send-email-albert.aribaud@free.fr> Message-ID: <4C9B1ECA.4050809@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Prafulla, Le 23/09/2010 11:16, Prafulla Wadaskar a ?crit : >> +/* Disable window 7, configure it for FLASH, enable it. */ > > Can you pls fix the ordering here so that win6/7 appears last in the code? Of course. >> @@ -265,6 +283,8 @@ int arch_misc_init(void) >> writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50); >> writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04); >> >> + /* initialize timer */ >> + timer_init_r(); > > Using CONFIG_MISC_INIT_R in the board configuration makes more sense here > And you can put this function in timer.c only and avoid exporting API through cpu.h Ok for misc_init_r() rather than arch_misc_init(). However I think this function is not timer-specific and thus belongs more to cpu.c than timer.c. >> \ No newline at end of file > > Pls fix this Will do. > Regards.. > Prafulla . . Thanks! Amicalement, -- Albert.