From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] [NEXT] arm926ejs: reduce code size with -msingle-pic-base
Date: Fri, 24 Sep 2010 18:08:44 +0200 [thread overview]
Message-ID: <4C9CCD0C.9030205@free.fr> (raw)
In-Reply-To: <AANLkTinLAcn5VcmVwxCOHYd7wXbptPK1PR-M0UfG469u@mail.gmail.com>
I think I have found the root cause of your issue.
I was actually lucky that it worked at all for me; and as Heiko's board
skipped relocation, it would not trigger the bug either... My computing
of r9/r10 in the relocate_code stage was plain wrong, based on the FLASH
execution location, not the RAM one. :/
I'll post a V2 patch set within the next hour -- Heiko, this second
patchset has your fixes except I mouved the r9/r10 recomputation inside
the #ifndef CONFIG_SKIP_RELOCATE_UBOOT, the logic being that if we can
skip relocation, then we are already running at the right location and
we don't need fixing the pic base either.
Ben and Heiko, please (re-)test the patch when it's out -- sorry for the
extra workload.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-09-24 16:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 13:57 [U-Boot] [PATCH 1/2] [NEXT] arm: change relocation flag from -fPIC to -fPIE Albert Aribaud
2010-09-22 13:57 ` [U-Boot] [PATCH 2/2] [NEXT] arm926ejs: reduce code size with -msingle-pic-base Albert Aribaud
2010-09-22 18:05 ` Ben Gardiner
2010-09-22 19:07 ` Albert ARIBAUD
2010-09-22 20:51 ` Ben Gardiner
2010-09-22 21:36 ` Albert ARIBAUD
2010-09-22 22:07 ` Albert ARIBAUD
2010-09-23 14:44 ` Ben Gardiner
2010-09-23 15:13 ` Albert ARIBAUD
2010-09-23 15:35 ` Ben Gardiner
2010-09-23 16:53 ` Ben Gardiner
2010-09-23 16:37 ` Ben Gardiner
2010-09-23 17:04 ` Albert ARIBAUD
2010-09-23 21:13 ` Ben Gardiner
2010-09-23 21:30 ` Albert ARIBAUD
2010-09-24 13:38 ` Ben Gardiner
2010-09-24 16:08 ` Albert ARIBAUD [this message]
2010-09-22 20:30 ` Wolfgang Denk
2010-09-22 20:55 ` Ben Gardiner
2010-09-22 21:11 ` Wolfgang Denk
2010-09-22 21:33 ` Ben Gardiner
2010-09-23 7:12 ` Heiko Schocher
2010-09-23 8:05 ` Albert ARIBAUD
2010-09-23 10:08 ` Heiko Schocher
2010-09-23 12:45 ` Albert ARIBAUD
2010-09-24 5:11 ` Heiko Schocher
2010-09-24 5:47 ` Albert ARIBAUD
2010-09-24 16:45 ` Rogan Dawes
2010-09-24 16:58 ` Rogan Dawes
2010-09-24 17:13 ` Albert ARIBAUD
2010-09-22 18:05 ` [U-Boot] [PATCH 1/2] [NEXT] arm: change relocation flag from -fPIC to -fPIE Ben Gardiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9CCD0C.9030205@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox