From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 30 Sep 2010 08:10:09 +0200 Subject: [U-Boot] [PATCH 12/17] post/i2c: Don't probe address 0 In-Reply-To: <1285787156-6005-12-git-send-email-ptyser@xes-inc.com> References: <1285787156-6005-1-git-send-email-ptyser@xes-inc.com> <1285787156-6005-12-git-send-email-ptyser@xes-inc.com> Message-ID: <4CA429C1.3030200@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Peter, Peter Tyser wrote: > According to the I2C specification device address 0 is the "general call > address", ie a broadcast address. The I2C specification states that the > format of a general call uses at least 2 bytes, which U-Boot's probing > routine does not adhere to. > > Not probing device address 0 will prevent possible issues with devices > that accept general calls. Additionally, this change shouldn't reduce > POST coverage since each I2C device should still be accessed via its > own, unique address. > > Signed-off-by: Peter Tyser > CC: hs at denx.de > --- > post/drivers/i2c.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) Thanks! Applies clean on top of master. Acked-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany