[U-Boot] [PATCH] Kirkwood: Changes specific to ARM relocation support

Wolfgang Denk
2010-09-30T17:34:44Z

Dear Prafulla Wadaskar,

In message <1285869240-17251-3-git-send-email-prafulla@marvell.com> you wrote:
> All Kirkwood based boards are supported for this new implementation
> ref: dovs/README.arm-relocation
>
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> include/configs/mv-common.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
> index ca9f33b..b80ad00 100644
> --- a/include/configs/mv-common.h
> +++ b/include/configs/mv-common.h
> @@ -56,6 +56,12 @@
> #error "Unsupported SoC"
> #endif
>
> +/* additions for new ARM relocation support */
> +#undef CONFIG_RELOC_FIXUP_WORKS

Is this really needed? As far as I can see CONFIG_RELOC_FIXUP_WORKS
is not defined anywhere in any ARM related fiole, so there shouldbe no
need to undef it.

> +#define CONFIG_SYS_SDRAM_BASE 0x00000000
> +#define CONFIG_SYS_INIT_SP_ADDR (0x00000000 + 0x1000 - \
> + CONFIG_SYS_GBL_DATA_SIZE)

This is wrong. You must not use RAM for the initial stack, or it
cannot be initialized / tested as it should be. If you hav eno static
RAM or other on-chip memory that could be used, you might try and lock
(some part of) the data cache and use this as storage for the initial
global data and stack.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He is truly wise who gains wisdom from another's mishap.