From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Sat, 02 Oct 2010 10:49:19 +0200
Subject: [U-Boot] ARM relocation,
 probably trivial mistake - back to original problem
In-Reply-To: <20101001125502.D0B4E1539A0@gemini.denx.de>
References: <4CA49746.2050301@emk-elektronik.de> <4CA4AEFF.3050101@denx.de>
	<20100930174308.070ECD2B48C@gemini.denx.de> <4CA570D3.9040406@denx.de>
	<4CA57468.6090702@free.fr> <4CA57762.3000201@denx.de>
	<4CA5821E.3070108@emk-elektronik.de> <4CA5873B.6040907@free.fr>
	<4CA590E6.6070701@emk-elektronik.de> <4CA59B89.6090207@denx.de>
	<4CA5BB7A.8050304@emk-elektronik.de>
	<20101001105506.A64D41539A0@gemini.denx.de>
	<4CA5BFEF.3090208@emk-elektronik.de>
	<20101001112125.4076E153A7E@gemini.denx.de>
	<4CA5C7DE.6010300@emk-elektronik.de>
	<20101001115908.A34411539A0@gemini.denx.de>
	<4CA5D26D.2090505@emk-elektronik.de>
	<4CA5D857.5010009@emk-elektronik.de>
	<20101001125502.D0B4E1539A0@gemini.denx.de>
Message-ID: <4CA6F20F.5080402@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Wolfgang, Reinhard,

Wolfgang Denk wrote:
> Dear Reinhard Meyer,
> 
> In message <4CA5D857.5010009@emk-elektronik.de> you wrote:
>> The environment issues still persist. I am at a loss
>> there now.
>>
>> Observation: the old style commands "setenv", "printenv", etc.
>> work, but any "env" command except for "env" alone crashes.
> 
> OK. If "printenv" works and "env print" fails then it has nothing to
> do with the environment code itself, as both call the same function.
> 
> It must have something to do with the implementation of subcommands
> then. See do_env() in "common/cmd_nvedit.c"; check if the command
> table address for find_cmd_tbl() is OK.
> 
> Eventually other commands with subcommands fail as well (i2c ?) ?

Yep, I think thats the direction. i2c should work, because the
subcommands get fixed in board_init_r() through i2c_reloc()

For fixing commandtable (and subcommands) I made a common
function fixup_cmdtable() in common/command.c see also
commit 620f1f6a64095ed558e68d37f1965d015cd49b02

Note: For powerpc this fixups are not needed, so
CONFIG_RELOC_FIXUP_WORKS is defined for powerpc ... don;t
sure, how exactly this work on powerpc ...

bye,
Heiko

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany