[U-Boot] ARM relocation, question to Heiko

Wolfgang Denk
2010-10-04T21:10:31Z

Dear Joakim Tjernlund,

In message <OFF06E784F.A10A5A15-ONC12577B2.0065FB3C-C12577B2.0066D69F@transmode.se> you wrote:
>
> :), actually it wasn't that bad. Wolfgang nearly accepted the code even :)

Yes, I was really tempted because I do appreciate the value of such a
feature.

> Mainly, I had to wrap code that accessed global data with a LINK_OFF() function
> that calculated the offset and only in code that executed before relocation.

That was the part that gave me the creeps. It looked too much
unreadable and error prone to me, especially as this is not only a
one-time conversion but has to be kept in mind for all changes to
related code.

I'm still undecided, to be honest.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...this does not mean that some of us should not want, in a rather
dispassionate sort of way, to put a bullet through csh's head."
- Larry Wall in <1992Aug6.221512.5963@netlabs.com>