From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation
Date: Mon, 04 Oct 2010 21:06:03 +1100 [thread overview]
Message-ID: <4CA9A70B.6030302@gmail.com> (raw)
In-Reply-To: <4CA9A582.8070107@mvista.com>
On 04/10/10 20:59, Sergei Shtylyov wrote:
> Hello.
>
> On 04-10-2010 7:37, Graeme Russ wrote:
>
>> To allow for 'load anywhere' images, the %ebp return pointer 'hack' must
>> be removed, so we cannot have two 'calls' to get_mem_size
>
>> Signed-off-by: Graeme Russ<graeme.russ@gmail.com>
> [...]
>
>> diff --git a/arch/i386/cpu/start.S b/arch/i386/cpu/start.S
>> index cb47ce7..9e6e0bf 100644
>> --- a/arch/i386/cpu/start.S
>> +++ b/arch/i386/cpu/start.S
>> @@ -93,6 +93,17 @@ mem_init_ret:
>> jmp get_mem_size
>> get_mem_size_ret:
>>
>> +#if CONFIG_SYS_SDRAM_ECC_ENABLE
>> + /* Skip ECC initialization if not starting from cold-reset */
>> + movl %ebx, %ecx
>> + andl $GD_FLG_COLD_BOOT, %ecx
>> + jz ecc_init_ret
>
> But the label you added is called 'init_ecc_ret'. Are you sure the
> name is correct here?
Yes, if the board has not been cold-booted (i.e. a new U-Boot image has
been loaded into RAM and executed) we must skip ECC initialization (it
destroys the contents of memory)
>
>> + mov $init_ecc_ret, %ebp
>> + jmp init_ecc
>> +
>> +init_ecc_ret:
>> +#endif
>> +
>> /* Check we have enough memory for stack */
>> movl $CONFIG_SYS_STACK_SIZE, %ecx
>> cmpl %ecx, %eax
>
> WBR, Sergei
>
Regards,
Graeme
next prev parent reply other threads:[~2010-10-04 10:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 3:37 [U-Boot] [PATCH 00/19] x86: Create fully relocatable U-Boot image Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 01/19] x86: Make CONFIG_RELOC_FIXUP_WORKS generic for all x86 boards Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 02/19] x86: Use TEXT_BASE in linker scripts Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 03/19] x86: zboot update Graeme Russ
2010-10-04 9:54 ` Sergei Shtylyov
2010-10-04 10:00 ` Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 04/19] x86: use gc sections to reduce image size Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 05/19] x86: Move loading of GTD to C code Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 06/19] x86: Coding Style Cleanup Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 07/19] x86: Change compiler options Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 08/19] x86: Fix %ss and %esp in register structure for interrupts Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 09/19] x86: Remove progress indication in low-level init Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation Graeme Russ
2010-10-04 9:59 ` Sergei Shtylyov
2010-10-04 10:06 ` Graeme Russ [this message]
2010-10-04 10:21 ` Wolfgang Denk
2010-10-04 21:49 ` Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 11/19] x86: Remove usage of %ebp as a return pointer Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 12/19] x86: Don't clobber %ebx Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 13/19] x86: Dont clobber %eax after getting memory size Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 14/19] x86: Place global data below stack before entering C Graeme Russ
2010-10-04 3:37 ` [U-Boot] [PATCH 15/19] x86: Set cold/warm boot flag Graeme Russ
2010-10-04 3:38 ` [U-Boot] [PATCH 16/19] x86: Rename linker script symbols Graeme Russ
2010-10-04 3:38 ` [U-Boot] [PATCH 17/19] x86: Rearrange linker script Graeme Russ
2010-10-04 3:38 ` [U-Boot] [PATCH 18/19] x86: Use loops instead of memcpy/memset in board_init_f Graeme Russ
2010-10-04 3:38 ` [U-Boot] [PATCH 19/19] x86: Implement fully relocatable image Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9A70B.6030302@gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox