public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env: fix cmd_env_sub fct pointers if CONFIG_RELOC_FIXUP_WORKS is not defined
Date: Tue, 05 Oct 2010 14:19:45 +0400	[thread overview]
Message-ID: <4CAAFBC1.7090507@mvista.com> (raw)
In-Reply-To: <1286257289-22313-1-git-send-email-hs@denx.de>

Hello.

On 05-10-2010 9:41, Heiko Schocher wrote:

> commit ea882baf9c17cd142c99e3ff640d3ab01daa5cec introduces
> a command_sub_table for the "env" command. On arm, avr32, m68k,
> mips and sparc architectures, relocation needs manual fixups,
> so add these fixups for this sub command table too.

> Tested on arm/qong board.
>            mips board (Ben NanoNote) from Xiangfu Liu
>            arm/AT91 board from Reinhard Meyer

> Signed-off-by: Heiko Schocher<hs@denx.de>

[...]

> diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
> index c3d63b8..16f5fb0 100644
> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
> @@ -837,6 +837,12 @@ static cmd_tbl_t cmd_env_sub[] = {
>   	U_BOOT_CMD_MKENT(set, CONFIG_SYS_MAXARGS, 0, do_env_set, "", ""),
>   };
>
> +#if !defined(CONFIG_RELOC_FIXUP_WORKS)
> +void env_reloc(void) {

    { should be on a separate line.

WBR, Sergei

  reply	other threads:[~2010-10-05 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05  5:41 [U-Boot] [PATCH] env: fix cmd_env_sub fct pointers if CONFIG_RELOC_FIXUP_WORKS is not defined Heiko Schocher
2010-10-05 10:19 ` Sergei Shtylyov [this message]
2010-10-05 12:17 ` [U-Boot] [PATCH v2] " Heiko Schocher
2010-10-06 20:35   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAAFBC1.7090507@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox