public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mark Vels <mark.vels@team-embedded.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix define for MPC5121 ADS board.
Date: Tue, 05 Oct 2010 21:20:23 +0200	[thread overview]
Message-ID: <4CAB7A77.1090308@team-embedded.nl> (raw)
In-Reply-To: <20101005182107.BE6281539A0@gemini.denx.de>

Dear Wolfgang,

On 05/10/10 20:21, Wolfgang Denk wrote:
> Dear mark.vels at team-embedded.nl,
> 
> In message <1286293579-26587-1-git-send-email-mark.vels@team-embedded.nl> you wrote:
>> Originally the Makefile defines CONFIG_ADS5121_REV2 when configuring
>> for board mpc5121ads_rev2. The config in include/configs/mpc5121ads.h
>> expects a define CONFIG_MPC5121ADS_REV2 for this.
>> Therefore there are two defines used but only 1 is defined.
>> This patch renames references to CONFIG_ADS5121_REV2 to CONFIG_MPC5121ADS_REV2
>> to have one common define.
>>
>> This patch fixes faulty mem size detection caused by wrong config in
>> include/configs/mpc5121ads.h
> 
> Thanks. But... should we not rather drop that code completely?  I
> guess the number of remaining Rev. 2 boards should be epsilon.  Do you
> think these veterans are still in use anywhere?

Hehe, well there is at least the one rev 2 board that I got from the customer on my desk at the moment. That's why I
tried to build and execute this config.

I really can't tell if there are many more around so I'd like to leave it up to the experts if it is necessary to keep
the code in. I am really glad though that it still is right now because it would have costed me a considerable amount of
time to figure out the differences between the different revs.

Best regards,

Mark

  reply	other threads:[~2010-10-05 19:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 15:46 [U-Boot] [PATCH] Fix define for MPC5121 ADS board mark.vels at team-embedded.nl
2010-10-05 18:21 ` Wolfgang Denk
2010-10-05 19:20   ` Mark Vels [this message]
2010-10-05 19:37     ` Wolfgang Denk
2010-10-13 19:32 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAB7A77.1090308@team-embedded.nl \
    --to=mark.vels@team-embedded.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox