public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] VCMA9 build fails: ARM board references PPC4xx header
@ 2010-10-05 18:55 Wolfgang Denk
  2010-10-06  7:38 ` "David Müller (ELSOFT AG)"
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2010-10-05 18:55 UTC (permalink / raw)
  To: u-boot

Dear David & Peter,

since Stefan's ppc4xx reorganization patches (commit b36df561:
"ppc4xx: Move ppc4xx headers to powerpc include directory") the
building of the VCMA9 breaks with this error message:

../common/memtst.c:51:28: error: asm/ppc4xx-i2c.h: No such file or directory

The problem comes from board/mpl/common/memtst.c which contains an
unconditional "#include <asm/ppc4xx-i2c.h>" which is obviously wrong
when the file gets compiled for an ARM board as VCMA9.

Can you please provide a fix?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Everything should be made as simple as possible, but not simpler."
                                                    - Albert Einstein

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] VCMA9 build fails: ARM board references PPC4xx header
  2010-10-05 18:55 [U-Boot] VCMA9 build fails: ARM board references PPC4xx header Wolfgang Denk
@ 2010-10-06  7:38 ` "David Müller (ELSOFT AG)"
  2010-10-06 12:47   ` Peter Tyser
  0 siblings, 1 reply; 3+ messages in thread
From: "David Müller (ELSOFT AG)" @ 2010-10-06  7:38 UTC (permalink / raw)
  To: u-boot

Wolfgang Denk schrieb:
> The problem comes from board/mpl/common/memtst.c which contains an
> unconditional "#include <asm/ppc4xx-i2c.h>" which is obviously wrong
> when the file gets compiled for an ARM board as VCMA9.
> 
> Can you please provide a fix?

The solution is to remove the include completely as it is not needed at all.

Dave
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-memtst.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20101006/a321175e/attachment.txt 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] VCMA9 build fails: ARM board references PPC4xx header
  2010-10-06  7:38 ` "David Müller (ELSOFT AG)"
@ 2010-10-06 12:47   ` Peter Tyser
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Tyser @ 2010-10-06 12:47 UTC (permalink / raw)
  To: u-boot

On Wed, 2010-10-06 at 09:38 +0200, "David M?ller (ELSOFT AG)" wrote:
> Wolfgang Denk schrieb:
> > The problem comes from board/mpl/common/memtst.c which contains an
> > unconditional "#include <asm/ppc4xx-i2c.h>" which is obviously wrong
> > when the file gets compiled for an ARM board as VCMA9.
> > 
> > Can you please provide a fix?
> 
> The solution is to remove the include completely as it is not needed at all.

Is there any reason to not remove the memtst.c file altogether as in
this patch:
http://lists.denx.de/pipermail/u-boot/2010-October/078649.html ?

Best,
Peter

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-06 12:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-05 18:55 [U-Boot] VCMA9 build fails: ARM board references PPC4xx header Wolfgang Denk
2010-10-06  7:38 ` "David Müller (ELSOFT AG)"
2010-10-06 12:47   ` Peter Tyser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox