From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 06 Oct 2010 14:07:25 +0400 Subject: [U-Boot] [PATCH 2/4] sf: spansion: fixing erasing when sector size >64KiB In-Reply-To: <1286350635-24645-3-git-send-email-vapier@gentoo.org> References: <1286350635-24645-1-git-send-email-vapier@gentoo.org> <1286350635-24645-3-git-send-email-vapier@gentoo.org> Message-ID: <4CAC4A5D.4060902@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 06-10-2010 11:37, Mike Frysinger wrote: > From: Marc-Andr? H?bert > The spansion_erase currently only works when the sector size is 64KB. > cmd[1] should contain the higher 8 bit of the 24 bit address of the > sector to be erased. Currently it is holding the sector index to be > erased which happens to be the same thing when the sector size is > 64KB. > Signed-off-by: Marc-Andre Hebert > Signed-off-by: Mike Frysinger > --- > drivers/mtd/spi/spansion.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c > index d6c1a5f..94489af 100644 > --- a/drivers/mtd/spi/spansion.c > +++ b/drivers/mtd/spi/spansion.c [...] > @@ -274,8 +273,8 @@ int spansion_erase(struct spi_flash *flash, u32 offset, size_t len) > } > > ret = 0; > - for (actual = 0; actual< len; actual++) { > - cmd[1] = (offset / sector_size) + actual; > + for (actual = 0; actual< len; actual+=sector_size) { Please put spaces around += to keep the style consistent. WBR, Sergei