From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Moore Date: Wed, 06 Oct 2010 20:01:03 +0200 Subject: [U-Boot] [PATCH V2] orion5x: optimize window size computation In-Reply-To: <1286376371-8180-1-git-send-email-albert.aribaud@free.fr> References: <1286376371-8180-1-git-send-email-albert.aribaud@free.fr> Message-ID: <4CACB95F.1000001@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Sorry Albert I missed this one last time :( Le 06/10/2010 16:46, Albert Aribaud a ?crit : > + * 1) A sizeval equal to 0x0 specifies 4 TB s/TB/GB/ or maybe even s/TB/GiB/ Question: are MB, GB, ... or MiB, GiB, ... preferred in U-Boot? I generally try to use the "i" versions where appropriate. In fact I used a KiB below: > + * Calculate the number of 64 KiB blocks needed minus one (rounding up). IMHO whatever the choice, it would be preferable to be consistent throughout. Cheers, Chris