From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] orion5x: optimize window size computation
Date: Wed, 06 Oct 2010 20:35:12 +0200 [thread overview]
Message-ID: <4CACC160.8090105@free.fr> (raw)
In-Reply-To: <4CACB95F.1000001@free.fr>
Le 06/10/2010 20:01, Chris Moore a ?crit :
> Hi,
>
> Sorry Albert I missed this one last time :(
>
> Le 06/10/2010 16:46, Albert Aribaud a ?crit :
>> + * 1) A sizeval equal to 0x0 specifies 4 TB
>
> s/TB/GB/ or maybe even s/TB/GiB/
>
> Question: are MB, GB, ... or MiB, GiB, ... preferred in U-Boot?
/me slaps himself.
One day, I'll get this one right the first time around, you'll see.
> I generally try to use the "i" versions where appropriate.
> In fact I used a KiB below:
>
>> + * Calculate the number of 64 KiB blocks needed minus one (rounding up).
>
> IMHO whatever the choice, it would be preferable to be consistent
> throughout.
Indeed, and as always, I prefer the les ambiguous choice: 4 TiB it is.
> Cheers,
> Chris
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-10-06 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 14:46 [U-Boot] [PATCH V2] orion5x: optimize window size computation Albert Aribaud
2010-10-06 18:01 ` Chris Moore
2010-10-06 18:35 ` Albert ARIBAUD [this message]
2010-10-06 18:37 ` Albert ARIBAUD
2010-10-06 19:24 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CACC160.8090105@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox