From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c
Date: Fri, 08 Oct 2010 15:04:15 +0400 [thread overview]
Message-ID: <4CAEFAAF.3080005@mvista.com> (raw)
In-Reply-To: <1286525010-13277-1-git-send-email-sbabic@denx.de>
Hello.
On 08-10-2010 12:03, Stefano Babic wrote:
> mmc_initialize is not called at the startup if the
> relocation takes place and the environment is stored
> into a MMC card.
> Signed-off-by: Stefano Babic<sbabic@denx.de>
[...]
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 5f2dfd0..704ddcb 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -775,6 +775,11 @@ void board_init_r (gd_t *id, ulong dest_addr)
> nand_init(); /* go init the NAND */
> #endif
>
> +#ifdef CONFIG_GENERIC_MMC
> + puts ("MMC: ");
> + mmc_initialize (bd);
This wouldn't pass checkpatch.pl. Spaces before ( are not allowed.
WBR, Sergei
next prev parent reply other threads:[~2010-10-08 11:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 8:03 [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c Stefano Babic
2010-10-08 11:04 ` Sergei Shtylyov [this message]
2010-10-08 11:26 ` Stefano Babic
2010-10-08 13:39 ` Steve Sakoman
2010-10-08 13:42 ` Steve Sakoman
2010-10-08 16:05 ` Stefano Babic
2010-10-08 16:21 ` Steve Sakoman
2010-10-08 18:13 ` Stefano Babic
2010-10-08 16:03 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAEFAAF.3080005@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox