From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 08 Oct 2010 15:04:15 +0400 Subject: [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c In-Reply-To: <1286525010-13277-1-git-send-email-sbabic@denx.de> References: <1286525010-13277-1-git-send-email-sbabic@denx.de> Message-ID: <4CAEFAAF.3080005@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 08-10-2010 12:03, Stefano Babic wrote: > mmc_initialize is not called at the startup if the > relocation takes place and the environment is stored > into a MMC card. > Signed-off-by: Stefano Babic [...] > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c > index 5f2dfd0..704ddcb 100644 > --- a/arch/arm/lib/board.c > +++ b/arch/arm/lib/board.c > @@ -775,6 +775,11 @@ void board_init_r (gd_t *id, ulong dest_addr) > nand_init(); /* go init the NAND */ > #endif > > +#ifdef CONFIG_GENERIC_MMC > + puts ("MMC: "); > + mmc_initialize (bd); This wouldn't pass checkpatch.pl. Spaces before ( are not allowed. WBR, Sergei