From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 08 Oct 2010 18:05:41 +0200 Subject: [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c In-Reply-To: References: <1286525010-13277-1-git-send-email-sbabic@denx.de> Message-ID: <4CAF4155.40009@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Steve Sakoman wrote: >> I'll revise my patch to add the missing gd->env_valid = 1; and re-test. > > Hmm . . . looking at env_nand.c I see that it doesn't do gd->env_valid > = 1 either, which is probably why I removed it last night. > > Any idea whether it is actually required? Seems to work fine without it! I have understood, it is not required if we call env_import and we require to verify the checksum. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================