public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c
Date: Fri, 08 Oct 2010 20:13:29 +0200	[thread overview]
Message-ID: <4CAF5F49.1060102@denx.de> (raw)
In-Reply-To: <AANLkTinxn4rUeOBFPo9_WH8AV2J+hgSK3EhpzG2xc225@mail.gmail.com>

Steve Sakoman wrote:
> On Fri, Oct 8, 2010 at 9:05 AM, Stefano Babic <sbabic@denx.de> wrote:
>> Steve Sakoman wrote:
>>
>>>> I'll revise my patch to add the missing gd->env_valid = 1; and re-test.
>>> Hmm . . . looking at env_nand.c I see that it doesn't do gd->env_valid
>>> = 1 either, which is probably why I removed it last night.
>>>
>>> Any idea whether it is actually required?  Seems to work fine without it!
>> I have understood, it is not required if we call env_import and we
>> require to verify the checksum.
> 
> OK, thanks!
> 
> Would you like me to submit the patch or would you like to revise & resubmit?

No problem at all - you can submit your patch, as it seems to me more
complete as mine.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2010-10-08 18:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08  8:03 [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c Stefano Babic
2010-10-08 11:04 ` Sergei Shtylyov
2010-10-08 11:26   ` Stefano Babic
2010-10-08 13:39 ` Steve Sakoman
2010-10-08 13:42   ` Steve Sakoman
2010-10-08 16:05     ` Stefano Babic
2010-10-08 16:21       ` Steve Sakoman
2010-10-08 18:13         ` Stefano Babic [this message]
2010-10-08 16:03   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAF5F49.1060102@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox