From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 10 Oct 2010 19:53:53 +0400 Subject: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation In-Reply-To: References: <1286574569.2105.1.camel@quadra> <4CB1A7A6.90706@mvista.com> <4CB1D343.9030706@mvista.com> Message-ID: <4CB1E191.90003@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10-10-2010 19:47, Steve Sakoman wrote: >>>>> The crash was occuring in env_relocate because it was being called prior >>>>> to mmc_initialize. This patch moves the MMC initialization earlier in >>>>> the init process. >>>>> This patch also cleans up the env_relocate_spec code in env_mmc.c >>>>> Developed jointly with Stefano Babic >>>>> Signed-off-by: Steve Sakoman >>>>> --- >>>>> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c >>>>> index 5f2dfd0..0e2f129 100644 >>>>> --- a/arch/arm/lib/board.c >>>>> +++ b/arch/arm/lib/board.c >>>>> @@ -779,6 +779,11 @@ void board_init_r (gd_t *id, ulong dest_addr) >>>>> onenand_init(); >>>>> #endif >>>>> >>>>> +#ifdef CONFIG_GENERIC_MMC >>>>> + puts ("MMC: "); >>>>> + mmc_initialize (bd); >>>> This would cause checkpatch.pl to complain -- no spaces allowed before >>>> (. >>> I will resubmit a V2 with that change as well as Stefano's Signed-off-by >> You've posted V2 with Stefano's ACK... and this line unchanged. :-) > ??? > +#ifdef CONFIG_GENERIC_MMC > + puts("MMC: "); > + mmc_initialize (bd); > +#endif > + > It looks changed to me! Indeed, I have ovelooked that first line under #ifdef was changed. But not the second. ;-) > Steve WBR, Sergei