From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5 1/2] MTD/SPI: introduce table driven probing
Date: Mon, 11 Oct 2010 10:30:11 +0200 [thread overview]
Message-ID: <4CB2CB13.7040302@emk-elektronik.de> (raw)
In-Reply-To: <201010110417.02557.vapier@gentoo.org>
Dear Mike Frysinger,
>> NONE of the existing functions work with expansion, so they all get the
>> unshifted, full ID buffer.
>
> err, right. was thinking it also shifted off the manu id byte and not just
> the continuation bytes.
>
> i'll tweak the patch i posted and pull in your ramtron patch.
Thanks.
>
>> If you provide the unshifted buffer to the function, the function should
>> get the shift amount as well. Otherwise the function will again have look
>> how many 0x7e's to skip....
>
> not really. the probe funcs already know the layout of the idcode, so
> starting at a constant offset of 3 is the same as starting at 1.
True. I was already contemplating the possibility of one probe function
having to deal with different amounts of shift... But this would not
work safe in either method right now.
(Assuming the unlikely case that 7e 7e 7e 55 and 7e 7e 55 have to be handled
by the same probe function...)
This would indeed favour passing the unshifted ID buffer for such functions
to find out the amount of 7f's. If you favour that, I am game with it. But I
will resubmit the ramtron part only when the new probe is in mainline and
I have rebased my tree to it.
Reinhard
next prev parent reply other threads:[~2010-10-11 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 14:56 [U-Boot] [PATCH V5 0/2] Patches to support Ramtron FRAMs Reinhard Meyer
2010-10-05 14:56 ` [U-Boot] [PATCH V5 1/2] MTD/SPI: introduce table driven probing Reinhard Meyer
2010-10-05 14:56 ` [U-Boot] [PATCH V5 2/2] MTD/SPI: add support for Ramtron FRAMs Reinhard Meyer
2010-10-11 7:33 ` Mike Frysinger
2010-10-11 7:28 ` [U-Boot] [PATCH V5 1/2] MTD/SPI: introduce table driven probing Mike Frysinger
2010-10-11 7:56 ` Reinhard Meyer
2010-10-11 8:17 ` Mike Frysinger
2010-10-11 8:30 ` Reinhard Meyer [this message]
2010-10-13 1:19 ` Mike Frysinger
2010-10-11 7:31 ` [U-Boot] [PATCH] sf: turn probe switch into a lookup table Mike Frysinger
2010-10-11 8:29 ` [U-Boot] [PATCH 1/2] " Mike Frysinger
2010-10-11 8:29 ` [U-Boot] [PATCH 2/2] sf: ramtron: new spi fram driver Mike Frysinger
2010-10-13 7:44 ` Reinhard Meyer
2010-10-13 13:43 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB2CB13.7040302@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox