public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc5xxx_fec: add call to reset_phy() after PHY initialization
Date: Mon, 11 Oct 2010 23:11:08 -0700	[thread overview]
Message-ID: <4CB3FBFC.70502@gmail.com> (raw)
In-Reply-To: <1282208946-18823-1-git-send-email-yanok@emcraft.com>

  Hi Ilya,

On 8/19/2010 2:09 AM, Ilya Yanok wrote:
> Some boards need their board-specific PHY quirks to be called
> to PHY to work normally. As mpc5xxx_fec driver uses on demand
> PHY initialization and can even reinit PHY during normal operation
> we can't count on reset_phy() call from arch/<arch>/lib/board.c
> (it is most likely called _before_ we init the PHY from the
> driver) so we need to add call to reset_phy() directly in the
> driver.
>
> Cc: Ben Warren<biggerbadderben@gmail.com>
> Signed-off-by: Ilya Yanok<yanok@emcraft.com>
> ---
>   drivers/net/mpc5xxx_fec.c |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/mpc5xxx_fec.c b/drivers/net/mpc5xxx_fec.c
> index c88e596..bc8c922 100644
> --- a/drivers/net/mpc5xxx_fec.c
> +++ b/drivers/net/mpc5xxx_fec.c
> @@ -250,6 +250,13 @@ static int mpc5xxx_fec_init(struct eth_device *dev, bd_t * bis)
>   	mpc5xxx_fec_init_phy(dev, bis);
>
>   	/*
> +	 * Call board-specific PHY fixups (if any)
> +	 */
> +#ifdef CONFIG_RESET_PHY_R
> +	reset_phy();
> +#endif
> +
> +	/*
>   	 * Initialize RxBD/TxBD rings
>   	 */
>   	mpc5xxx_fec_rbd_init(fec);
Applied to net repo.  Please accept my sincere apologies for taking so 
long to process.

regards,
Ben

      parent reply	other threads:[~2010-10-12  6:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19  9:09 [U-Boot] [PATCH] mpc5xxx_fec: add call to reset_phy() after PHY initialization Ilya Yanok
2010-09-13  9:33 ` Wolfgang Denk
2010-09-28 17:44   ` Wolfgang Denk
2010-10-12  6:11 ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB3FBFC.70502@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox