From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Mon, 11 Oct 2010 23:11:42 -0700 Subject: [U-Boot] [PATCH v6 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr In-Reply-To: <934934af538156cc343de6f72f9f1be95f51a94b.1285250191.git.bengardiner@nanometrics.ca> References: <934934af538156cc343de6f72f9f1be95f51a94b.1285250191.git.bengardiner@nanometrics.ca> Message-ID: <4CB3FC1E.2000903@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ben, On 9/23/2010 6:58 AM, Ben Gardiner wrote: > This patch proposes to migrate the davinci_emac driver to using the > eth_device->write_hwaddr function pointer as suggested by Ben Warren. > > All the davinci boards had the behaviour, prior to this patch, of > sync'ing the environment variable enetaddr with the MAC address read > from non-volatile storage on boot -- when the two locations disagreed, > the environment variable value took precendence. This patch keeps the > same behaviour but lets eth_initialize take care of it. > > This patch refactors davinci_emac setup in the boards so that the MAC > address is read from non-volatile storage into the environment variable > and then the environment variable value is use in eth_intialize. The > only exception is the direct call to davinci_eth_set_mac_addr made by > the da830evm board init which was changed into an assignment of the > enetaddr field. > > Signed-off-by: Ben Gardiner > Tested-by: Nick Thompson > CC: Ben Warren > Added to net repo. regards, Ben