From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 13 Oct 2010 07:27:00 +0200 Subject: [U-Boot] [PATCH] [NEW_RELOC] arm1136, qong: add support for ELF relocations In-Reply-To: <4CB478D4.3030702@free.fr> References: <1286883087-362-1-git-send-email-hs@denx.de> <4CB478D4.3030702@free.fr> Message-ID: <4CB54324.4030200@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Albert, Albert ARIBAUD wrote: > Le 12/10/2010 13:31, Heiko Schocher a ?crit : >> Signed-off-by: Wolfgang Denk >> Signed-off-by: Heiko Schocher >> --- > > I assume this is [ELF_RELOC], not [NEW_RELOC], right? I'm asking because > using the same tag for all "elf_reloc" branch related patches makes it > easier to find them all back. Ups, you are right, fix this. >> diff --git a/arch/arm/cpu/arm1136/u-boot.lds b/arch/arm/cpu/arm1136/u-boot.lds > >> + __dynsym_start = .; >> + .dynsym : { *(.dynsym) } >> + >> __got_start = .; >> . = ALIGN(4); >> .got : { *(.got) } > > Do you need to keep .got in the linker file? I think it can be removed. Hmm.. think you are right, I try this, thanks. > You could also add > > /DISCARD/ : { *(.dynstr*) } > /DISCARD/ : { *(.dynamic*) } > /DISCARD/ : { *(.plt*) } > /DISCARD/ : { *(.interp*) } > /DISCARD/ : { *(.gnu*) } > > At the end of the sections statement. Ok. >> diff --git a/include/configs/qong.h b/include/configs/qong.h > >> +#define CONFIG_RELOC_FIXUP_WORKS > > I believe this is now common to all ARMs, hence unneeded in config files. Hmm.. instead we should remove in arch/arm/include/asm/config.h 24 #if defined(CONFIG_SYS_ARM_WITHOUT_RELOC) 25 /* Relocation to SDRAM works on all ARM boards */ 26 #define CONFIG_RELOC_FIXUP_WORKS 27 #endif this #if defined(CONFIG_SYS_ARM_WITHOUT_RELOC) ... #endif And remove for all arm board, which now define CONFIG_RELOC_FIXUP_WORKS this in the config file. If you are OK with that, I can make such a patch. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany