From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Wed, 13 Oct 2010 07:31:10 +0200
Subject: [U-Boot] [PATCH] [NEW_RELOC] arm1136,
	qong: add support for ELF relocations
In-Reply-To: <20101012180046.75E9A151F66@gemini.denx.de>
References: <1286883087-362-1-git-send-email-hs@denx.de>
	<4CB478D4.3030702@free.fr> <20101012180046.75E9A151F66@gemini.denx.de>
Message-ID: <4CB5441E.2060103@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Wolfgang,

Wolfgang Denk wrote:
> Dear Albert ARIBAUD,
> 
> In message <4CB478D4.3030702@free.fr> you wrote:
>> Le 12/10/2010 13:31, Heiko Schocher a ?crit :
>>> Signed-off-by: Wolfgang Denk<wd@denx.de>
>>> Signed-off-by: Heiko Schocher<hs@denx.de>
>>> ---
>> I assume this is [ELF_RELOC], not [NEW_RELOC], right? I'm asking because
>> using the same tag for all "elf_reloc" branch related patches makes it
>> easier to find them all back.
>>
>>> diff --git a/arch/arm/cpu/arm1136/u-boot.lds b/arch/arm/cpu/arm1136/u-boot.lds
>>> +	__dynsym_start = .;
>>> +	.dynsym : { *(.dynsym) }
>>> +
>>>   	__got_start = .;
>>>   	. = ALIGN(4);
>>>   	.got : { *(.got) }
>> Do you need to keep .got in the linker file? I think it can be removed.
>>
>> You could also add
>>
>> 	/DISCARD/ : { *(.dynstr*) }
>> 	/DISCARD/ : { *(.dynamic*) }
>> 	/DISCARD/ : { *(.plt*) }
>> 	/DISCARD/ : { *(.interp*) }
>> 	/DISCARD/ : { *(.gnu*) }
>>
>> At the end of the sections statement.
> 
> Agreed.
> 
> Heiko, can you please retest / resubmit?  Thanks.
> 
>>> diff --git a/include/configs/qong.h b/include/configs/qong.h
>>> +#define	CONFIG_RELOC_FIXUP_WORKS
>> I believe this is now common to all ARMs, hence unneeded in config files.
> 
> This should then be done for all board, i. e. in a separate commit.

This should be done in arch/arm/include/asm/config.h

Hmm.. as I have to fix this patch for qong board, should I do a
patchseries which removes first CONFIG_RELOC_FIXUP_WORKS in config
files and then a second, which converts the qong board for elf
relocation?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany