From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 14 Oct 2010 16:06:44 +0200 Subject: [U-Boot] [PATCH] armv7, beagle: Second SDRAM bank don;t work In-Reply-To: <1287064487.7756.21.camel@quadra> References: <1287043393-2036-1-git-send-email-hs@denx.de> <20101014083852.EBE03134F26@gemini.denx.de> <1287064487.7756.21.camel@quadra> Message-ID: <4CB70E74.1000902@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Steve, Steve Sakoman wrote: > On Thu, 2010-10-14 at 10:38 +0200, Wolfgang Denk wrote: >> Dear Heiko Schocher, >> >> In message <1287043393-2036-1-git-send-email-hs@denx.de> you wrote: >>> since commit 3667cbeed5e3c4067e624e52a916b1ebb02c8f05 >>> on beagle board the second sdram bank didn;t longer >>> work. Since this patch sdram settings just get copied >>> from bank a, but CMD_NOP, CMD_PRECHARGE, CMD_AUTOREFRESH >>> are not executed and after that mr register is also >>> not updated. This patch adds this for the bank b. >> I would like to see Steve's ACK for the original Beagle board, and >> it's several versions. >> >> Steve, what Heiko forgets to mention here is that this problem happened >> on a EBV-Beagle, so there are certrain hardware differences. > > I suspect that his using an EVB-Beagle (with associated EVB x-load) is > what is causing the issue for him. Yep, seems so. > With the introduction of the Beagle xM came the need to deal with > several types of POP memory, and the resulting need for customized setup > for the SDRC. > > This is best handled in x-load while running from SRAM, since timings > and mux setup are different for each memory type. > > The code in Beagle x-load currently looks like this: [...] > > The code in u-boot to copy bank 1 settings to bank 2 was a workaround so that Beagle users > who didn't update x-load immediately would at least have a functioning system. > > I don't think that Heiko's patch will do any harm and it might be a good idea so that EVB Yep, so I think too ... > Beagle users can use the standard Beagle u-boot. I will have to verify that it does no > harm on all the various Beagle versions first though. > > I will Ack or Nack after I do some testing. Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany