From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Fix emaclite driver to support little-endian microblaze
Date: Thu, 14 Oct 2010 23:26:21 +0400 [thread overview]
Message-ID: <4CB7595D.7090305@mvista.com> (raw)
In-Reply-To: <1286761307-17009-1-git-send-email-monstr@monstr.eu>
Hello.
On 10/11/10 05:41, Michal Simek wrote:
> Support New emaclite AXI IP.
> Signed-off-by: Michal Simek<monstr@monstr.eu>
> CC: Ben Warren<biggerbadderben@gmail.com>
[...]
> diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclite.c
> index 455ce0c..76af939 100644
> --- a/drivers/net/xilinx_emaclite.c
> +++ b/drivers/net/xilinx_emaclite.c
> @@ -309,7 +309,7 @@ static int emaclite_recv(struct eth_device *dev)
> #endif
> }
> /* Get the length of the frame that arrived */
> - switch(((in_be32 (baseaddress + XEL_RXBUFF_OFFSET + 0xC)) &
> + switch(((ntohl(in_be32 (baseaddress + XEL_RXBUFF_OFFSET + 0xC))) &
This wouldn't pass checkpatch.pl -- spaces before ( not allowed.
> 0xFFFF0000 )>> 16) {
> case 0x806:
> length = 42 + 20; /* FIXME size of ARP */
> @@ -317,7 +317,7 @@ static int emaclite_recv(struct eth_device *dev)
> break;
> case 0x800:
> length = 14 + 14 +
> - (((in_be32 (baseaddress + XEL_RXBUFF_OFFSET + 0x10)) &
> + (((ntohl(in_be32 (baseaddress + XEL_RXBUFF_OFFSET + 0x10))) &
Same here.
WBR, Sergei
prev parent reply other threads:[~2010-10-14 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 1:41 [U-Boot] [PATCH] net: Fix emaclite driver to support little-endian microblaze Michal Simek
2010-10-11 1:41 ` [U-Boot] [PATCH v2] net: Move Emaclite to NET_MULTI Michal Simek
2010-10-12 6:34 ` Ben Warren
2010-10-12 6:34 ` [U-Boot] [PATCH] net: Fix emaclite driver to support little-endian microblaze Ben Warren
2010-10-14 19:26 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB7595D.7090305@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox