public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx25: Fix reset
Date: Sat, 16 Oct 2010 21:39:21 +0400	[thread overview]
Message-ID: <4CB9E349.2060105@mvista.com> (raw)
In-Reply-To: <1286884156-30182-1-git-send-email-weisserm@arcor.de>

Hello.

On 12-10-2010 15:49, Matthias Weisser wrote:

> This patch fixes the reset command on imx25

> Signed-off-by: Matthias Weisser<weisserm@arcor.de>
[...]
> diff --git a/arch/arm/cpu/arm926ejs/mx25/reset.c b/arch/arm/cpu/arm926ejs/mx25/reset.c
> index 1e33150..a5fd170 100644
> --- a/arch/arm/cpu/arm926ejs/mx25/reset.c
> +++ b/arch/arm/cpu/arm926ejs/mx25/reset.c
> @@ -42,15 +42,9 @@
>   void reset_cpu (ulong ignored)
>   {
>   	struct wdog_regs *regs = (struct wdog_regs *)IMX_WDT_BASE;
> -	/* Disable watchdog and set Time-Out field to 0 */
> -	writel (0x00000000,&regs->wcr);
>
> -	/* Write Service Sequence */
> -	writel (0x00005555,&regs->wsr);
> -	writel (0x0000AAAA,&regs->wsr);
> -
> -	/* Enable watchdog */
> -	writel (WCR_WDE,&regs->wcr);
> +	/* Enable watchdog and set Time-Out field to 0 (0.5s timeout) */
> +	writew (WCR_WDE,&regs->wcr);

    This wouldn't pass checkpatch.pl -- spaces not allowed before (...

WBR, Sergei

      reply	other threads:[~2010-10-16 17:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-12 11:49 [U-Boot] [PATCH] imx25: Fix reset Matthias Weisser
2010-10-16 17:39 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB9E349.2060105@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox