From mboxrd@z Thu Jan  1 00:00:00 1970
From: Reinhard Meyer <u-boot@emk-elektronik.de>
Date: Sun, 17 Oct 2010 02:13:52 +0200
Subject: [U-Boot] [PATCH v2 1/5] Build: Add "board options" column to
 boards.cfg
In-Reply-To: <1287273462-14872-2-git-send-email-wd@denx.de>
References: <1286790310-5865-1-git-send-email-wd@denx.de>
	<1287273462-14872-2-git-send-email-wd@denx.de>
Message-ID: <4CBA3FC0.1010300@emk-elektronik.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

 > In case of simple options like '256M_U_BOOT', these expand to
 > "#define CONFIG_MK_256M_U_BOOT 1" in config.h . In case of
 > assignments like 'RAM=8192', these expand to "#define CONFIG_MK_RAM
 > 8192" in config.h .

Umm, what about:

 > Out of principle: please omit the "1" in all such cases unless you
 > really want to pass or test for such a numeric value anywhere. As far
 > as I can tell all relevant code uses only "#ifdef" or "defined(...)",
 > so not to confuse people better omit the irrelevant value.

Your own words ;)

If someone really needs the "1", they can always write "=1" in boards.cfg.

Best Regards,
Reinhard