public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] Blackfin: workaround anomaly 05000440
Date: Mon, 18 Oct 2010 00:10:49 +0400	[thread overview]
Message-ID: <4CBB5849.6030708@mvista.com> (raw)
In-Reply-To: <1287102237-29868-2-git-send-email-vapier@gentoo.org>

Hello.

On 15-10-2010 04:23, Mike Frysinger wrote:

> We cannot rely on the syscontrol rom func to program PLL_DIV with anomaly
> 05000440 is in effect, so manually program the MMR when necessary.

> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
[...]

> diff --git a/arch/blackfin/cpu/initcode.c b/arch/blackfin/cpu/initcode.c
> index 007f5ce..433d477 100644
> --- a/arch/blackfin/cpu/initcode.c
> +++ b/arch/blackfin/cpu/initcode.c
> @@ -391,7 +391,9 @@ program_clocks(ADI_BOOT_DATA *bs, bool put_into_srfs)
>
>   		/* Always programming PLL_LOCKCNT avoids Anomaly 05000430 */
>   		ADI_SYSCTRL_VALUES memory_settings;
> -		uint32_t actions = SYSCTRL_WRITE | SYSCTRL_PLLCTL | SYSCTRL_PLLDIV | SYSCTRL_LOCKCNT;
> +		uint32_t actions = SYSCTRL_WRITE | SYSCTRL_PLLCTL | SYSCTRL_LOCKCNT;

    An empty line is needed here...

> +		if (!ANOMALY_05000440)
> +			actions |= SYSCTRL_PLLDIV;
>   		if (CONFIG_HAS_VR) {
>   			actions |= SYSCTRL_VRCTL;
>   			if (CONFIG_VR_CTL_VAL&  FREQ_MASK)

WBR, Sergei

      reply	other threads:[~2010-10-17 20:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15  0:23 [U-Boot] [PATCH 1/2] Blackfin: update anomaly lists to latest sheets Mike Frysinger
2010-10-15  0:23 ` [U-Boot] [PATCH 2/2] Blackfin: workaround anomaly 05000440 Mike Frysinger
2010-10-17 20:10   ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBB5849.6030708@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox