public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] at91rm9200ek: convert to at91
Date: Mon, 18 Oct 2010 11:27:53 +0200	[thread overview]
Message-ID: <4CBC1319.4030604@gmail.com> (raw)
In-Reply-To: <4CBC07E8.7020901@emk-elektronik.de>

Dear Reinhard Meyer,

Am 18.10.2010 10:40, schrieb Reinhard Meyer:
> Dear Andreas Bie?mann,

>>>> @@ -113,10 +112,6 @@
>>>> #define CONFIG_DBGU
>>>> #undef CONFIG_USART0
>>>> #undef CONFIG_USART1
>>> Don't #undef what has never been defined.
>>
>> You know this is historic. This are the three possible interfaces for USART on this board. At least at91rm9200 known about DBGU ;) This will be addressed when merging at91rm9200/at91 and maybe avr32 usart implementation.
> 
> I know, its like that in almost all Atmel based boards. Even worse is the AT91 method,
> since some AT91 can have 6 UARTs. However unlikely that they are going to be used as console,
> this is awfully bad = <at91sam9260_ek.h>:
> 
> #define CONFIG_ATMEL_USART	1
> #undef CONFIG_USART0
> #undef CONFIG_USART1
> #undef CONFIG_USART2
> #define CONFIG_USART3		1	/* USART 3 is DBGU */
> Notice the last define !!!

I know that ...

> I once tried to cleanup that a bit, but it really would affect files all across AT91.

I plan to merge at91rm9200_usart and at91_usart for 2011.03. It will
introduce clear naming scheme in at91 (USRT3 vs DBGU). Also I plan to
remove the necessity to hardcode the base addresses in header of
at91_usart.c. But to do this we need a clean basis to test the changes.
Eg. at91rm9200ek and at91sam9260ek (i can get one from time to time) or
your at91sam9263 based boards. I also think a lot of avr32 stuff could
merge into the same drivers ... will have a look for that in future.

I do all of this in spare time at home therefore I go only little steps
... But currently are all arm boards broken (relocation), therefore is
now the time to introduce new interfaces. Do you think the same way?

regards

Andreas Bie?mann

  reply	other threads:[~2010-10-18  9:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-16  0:41 [U-Boot] [PATCH 0/3] new BSP for at91rm9200ek Andreas Bießmann
2010-10-16  0:41 ` [U-Boot] [PATCH 1/3] at91rm9200ek: convert to at91 Andreas Bießmann
2010-10-17 18:06   ` Reinhard Meyer
2010-10-17 18:40     ` Wolfgang Denk
2010-10-18  6:36       ` Andreas Bießmann
2010-10-18  6:46         ` Wolfgang Denk
2010-10-18  6:36     ` Andreas Bießmann
2010-10-18  8:40       ` Reinhard Meyer
2010-10-18  9:27         ` Andreas Bießmann [this message]
2010-10-18 11:21           ` Reinhard Meyer
2010-10-16  0:41 ` [U-Boot] [PATCH 2/3] at91rm9200: enable USB support Andreas Bießmann
2010-10-16  0:41 ` [U-Boot] [PATCH 3/3] at91rm9200ek: enbable " Andreas Bießmann
2010-10-18 20:58 ` [U-Boot] [PATCH v2 1/3] at91rm9200ek: convert to at91 Andreas Bießmann
2010-10-18 20:58   ` [U-Boot] [PATCH v2 2/3] at91rm9200: enable USB support Andreas Bießmann
2010-10-18 20:58   ` [U-Boot] [PATCH v2 3/3] at91rm9200ek: enbable " Andreas Bießmann
2010-10-18 21:37   ` [U-Boot] [PATCH v2 1/3] at91rm9200ek: convert to at91 Reinhard Meyer
2010-10-19  7:29     ` Andreas Bießmann
2010-10-19 13:52 ` [U-Boot] [PATCH 0/3] new BSP for at91rm9200ek Reinhard Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBC1319.4030604@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox