From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Lilja Date: Mon, 18 Oct 2010 21:50:33 +0200 Subject: [U-Boot] [PATCH] i.MX31: Fix Litekit board to use new ARM relocation support. In-Reply-To: <4CBC05BA.70505@denx.de> References: <1287251226-8450-1-git-send-email-lilja.magnus@gmail.com> <4CBC05BA.70505@denx.de> Message-ID: <4CBCA509.9000901@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On 2010-10-18 10:30, Stefano Babic wrote: > On 10/16/2010 07:47 PM, Magnus Lilja wrote: >> Tested on hardware. Boots Linux nicely. >> >> Signed-off-by: Magnus Lilja >> --- > > Hi Magnus, > >> @@ -31,12 +31,18 @@ DECLARE_GLOBAL_DATA_PTR; >> >> int dram_init (void) >> { >> - gd->bd->bi_dram[0].start = PHYS_SDRAM_1; >> - gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE; >> + gd->ram_size = PHYS_SDRAM_1_SIZE; > > Any reason to not use get_ram_size() ? Yes, lowlevel_init.S for the litekit board doesn't support autodetection of ram size. I suppose the SDRAM controller needs to be reprogrammed with the actual ool/row settings depending on the RAM size. Also, I prefer making one change in each patch so this patch updates the Litekit board to use the new relocation stuff. Regards, Magnus