public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC 3/4] ARMV7: OMAP: I2C driver: Restructure i2c_write_byte function
Date: Wed, 20 Oct 2010 08:08:08 +0200	[thread overview]
Message-ID: <4CBE8748.60300@denx.de> (raw)
In-Reply-To: <1287462940-19496-4-git-send-email-steve@sakoman.com>

Hello Steve,

Steve Sakoman wrote:
> This patch removes the "magic number" delays and instead
> monitors state changes in the status register bits.
> 
> Signed-off-by: Steve Sakoman <steve.sakoman@linaro.org>
> ---
>  drivers/i2c/omap24xx_i2c.c |   76 +++++++++++++++++++++++--------------------
>  1 files changed, 41 insertions(+), 35 deletions(-)

After trying this for the omap3_beagle board, I get an
compiler warning:

[hs at pollux u-boot]$ ./MAKEALL omap3_beagle
Configuring for omap3_beagle board...
omap24xx_i2c.c: In function 'i2c_write_byte':
omap24xx_i2c.c:221: warning: unused variable 'stat'
   text    data     bss     dec     hex filename
 218103   11412  202384  431899   6971b ./u-boot

--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with warnings or errors: 1 ( omap3_beagle )
----------------------------------------------------------
[hs at pollux u-boot]$

following patch fixes it.

BTW:
Just for the record, your patchset works fine and faster
on the beagle board, for example:

                 before your  after your
                 patchset     patchset
i2c probe        9s           0,4s
i2c md 48 0 100  17s          1s

would you post a v2 of this patch, and I add my
"Tested-by" to it, or is it OK, if I add my fix patch
to u-boot-i2c master?

  parent reply	other threads:[~2010-10-20  6:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  4:35 [U-Boot] [PATCH RFC 0/4] ARMV7: OMAP: I2C driver: Restructure code to eliminate udelay calls and improve performance Steve Sakoman
2010-10-19  4:35 ` [U-Boot] [PATCH RFC 1/4] ARMV7: OMAP: I2C driver: Use same timeout value as linux kernel driver Steve Sakoman
2010-10-20  5:49   ` Heiko Schocher
2010-10-19  4:35 ` [U-Boot] [PATCH RFC 2/4] ARMV7: OMAP: I2C driver: Restructure i2c_read_byte function Steve Sakoman
2010-10-20  5:50   ` Heiko Schocher
2010-10-19  4:35 ` [U-Boot] [PATCH RFC 3/4] ARMV7: OMAP: I2C driver: Restructure i2c_write_byte function Steve Sakoman
2010-10-20  5:50   ` Heiko Schocher
2010-10-20  6:08   ` Heiko Schocher [this message]
2010-10-20 13:11     ` Steve Sakoman
2010-10-20 13:22       ` Heiko Schocher
2010-10-19  4:35 ` [U-Boot] [PATCH RFC 4/4] ARMV7: OMAP: I2C driver: Restructure i2c_probe function Steve Sakoman
2010-10-20  5:51   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBE8748.60300@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox