From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 20 Oct 2010 08:08:08 +0200 Subject: [U-Boot] [PATCH RFC 3/4] ARMV7: OMAP: I2C driver: Restructure i2c_write_byte function In-Reply-To: <1287462940-19496-4-git-send-email-steve@sakoman.com> References: <1287462940-19496-1-git-send-email-steve@sakoman.com> <1287462940-19496-4-git-send-email-steve@sakoman.com> Message-ID: <4CBE8748.60300@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Steve, Steve Sakoman wrote: > This patch removes the "magic number" delays and instead > monitors state changes in the status register bits. > > Signed-off-by: Steve Sakoman > --- > drivers/i2c/omap24xx_i2c.c | 76 +++++++++++++++++++++++-------------------- > 1 files changed, 41 insertions(+), 35 deletions(-) After trying this for the omap3_beagle board, I get an compiler warning: [hs at pollux u-boot]$ ./MAKEALL omap3_beagle Configuring for omap3_beagle board... omap24xx_i2c.c: In function 'i2c_write_byte': omap24xx_i2c.c:221: warning: unused variable 'stat' text data bss dec hex filename 218103 11412 202384 431899 6971b ./u-boot --------------------- SUMMARY ---------------------------- Boards compiled: 1 Boards with warnings or errors: 1 ( omap3_beagle ) ---------------------------------------------------------- [hs at pollux u-boot]$ following patch fixes it. BTW: Just for the record, your patchset works fine and faster on the beagle board, for example: before your after your patchset patchset i2c probe 9s 0,4s i2c md 48 0 100 17s 1s would you post a v2 of this patch, and I add my "Tested-by" to it, or is it OK, if I add my fix patch to u-boot-i2c master?