From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Add labels to endifs and remove impossible conditional code block
Date: Thu, 21 Oct 2010 22:37:13 +0200 [thread overview]
Message-ID: <4CC0A479.4040900@emk-elektronik.de> (raw)
In-Reply-To: <20101021202257.DF79A1359B7@gemini.denx.de>
Dear Wolfgang Denk,
> In message<4CC09695.6070702@rocketmail.com> you wrote:
>> Labels added to endifs to aid readability of the net/bootp.c file.
>> A block of code was marked for conditional compilation but the condition
>> could never arise, the ifdef\endif code block has been deleted.
> ...
>
>> -#if defined(CONFIG_CMD_DHCP)
>> - *e++ = 53; /* DHCP Message Type */
>> - *e++ = 1;
>> - *e++ = DHCP_DISCOVER;
>> -
>> - *e++ = 57; /* Maximum DHCP Message Size */
>> - *e++ = 2;
>> - *e++ = (576 - 312 + OPT_SIZE)>> 16;
>> - *e++ = (576 - 312 + OPT_SIZE)& 0xff;
>> -#endif
>
> What makes you think CONFIG_CMD_DHCP was never used? There are 270+
> boards that use this!
Its in the ELSE part like this:
#if defined(CONFIG_CMD_DHCP)
...
#else
...
#if defined(CONFIG_CMD_DHCP)
...
#endif
...
#endif
Perhaps it should be investigated how it happened to become such dead code?
Best Regards,
Reinhard
next prev parent reply other threads:[~2010-10-21 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 19:37 [U-Boot] [PATCH] net: Add labels to endifs and remove impossible conditional code block Gray Remlin
2010-10-21 20:22 ` Wolfgang Denk
2010-10-21 20:37 ` Reinhard Meyer [this message]
2010-10-21 20:46 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC0A479.4040900@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox