[U-Boot] [PATCH] env_sf - Do not free flash environment on successful read

[Stefano Babic <sbabic@denx.de>]

On 10/22/2010 12:56 PM, Wolfgang Denk wrote:
> Dear Oliver Dillinger,
> 

Hi Wolfgang,

> Also, this patch is not correct. It is OK to call spi_flash_free()
> here.
> 
> 
> The bug is in saveenv() for the non-redundant case. The function has
> not been dapted to the new environment code, at all; for example, it
> fails to actually export the internally stored environment [there is
> no call to hexport()].

You mean there are several bugs here....if spi_flash_free() is correct,
then spi_flash_probe must be called inside the saveenv function, in case
env_flash is not set (so it is called only once).
And IMHO spi_flash_free() should be called for the redundant case, too
(why is it different from the non-redundant case?).

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================