From mboxrd@z Thu Jan  1 00:00:00 1970
From: Can Aydin <can.aydin@locatacorp.com>
Date: Mon, 25 Oct 2010 11:31:20 +1100
Subject: [U-Boot] [PATCH v2] Freescale 85xx/P1/P2 eSPI controller driver
In-Reply-To: <20101024122108.1D57211D921@gemini.denx.de>
References: <1287920728-6458-1-git-send-email-can.aydin@locatacorp.com>
	<20101024122108.1D57211D921@gemini.denx.de>
Message-ID: <4CC4CFD8.5030405@locatacorp.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear  Wolfgang Denk,


On 24/10/2010 11:21 PM, Wolfgang Denk wrote:
> Dear Can Aydin,
>
> In message<1287920728-6458-1-git-send-email-can.aydin@locatacorp.com>  you wrote:
>> Driver for the Freescale eSPI controller found in 85xx, P1/P2 and P4xx SoCs.
> ...
>> +static inline void write_u32_part (u32 * in, u32 * out, u8 size)
>> +{
>> +	int i;
>> +	u8 *ibyte = (u8 *) in;
>> +	u8 *obyte = (u8 *) out;
>> +
>> +	for (i = 0; i<  size; i++) {
>> +		obyte[i] = ibyte[i];
>> +	}
>> +}
> What is this cunction needed for?  Can you not use a plain memcpy()
> instead?
>
> If not, is it really sufficient you use plain memory read/write
> operations here, without any MBs or similar (i. e. are you sure that
> no I/O accessors are needed here) ?
Yes a plain memcpy would suffice there, that function was actually a 
leftover of some test code. I'll fix that and incorporate the other 
comments.

Regards,

Can Aydin