* [U-Boot] [PATCH] mmc: set tran_speed intead of hard setting
@ 2010-10-25 4:19 Jaehoon Chung
2010-10-25 8:11 ` Minkyu Kang
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2010-10-25 4:19 UTC (permalink / raw)
To: u-boot
This patch use card's tran_speed instead of hard setting value.
I think mmc_set_clock(mmc, 52000000) is not good idea.
because this is hard setting. we need use card's tran_speed.
So If card_caps did't support High speed, we need set card's speed value
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/mmc.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index c543d83..f1b5552 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -815,11 +815,12 @@ int mmc_startup(struct mmc *mmc)
if (mmc->card_caps & MMC_MODE_HS) {
if (mmc->card_caps & MMC_MODE_HS_52MHz)
- mmc_set_clock(mmc, 52000000);
+ mmc->tran_speed = 52000000;
else
- mmc_set_clock(mmc, 26000000);
- } else
- mmc_set_clock(mmc, 20000000);
+ mmc->tran_speed = 26000000;
+ }
+
+ mmc_set_clock(mmc, mmc->tran_speed);
}
/* fill in device description */
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] mmc: set tran_speed intead of hard setting
2010-10-25 4:19 [U-Boot] [PATCH] mmc: set tran_speed intead of hard setting Jaehoon Chung
@ 2010-10-25 8:11 ` Minkyu Kang
2010-11-17 1:20 ` Minkyu Kang
0 siblings, 1 reply; 3+ messages in thread
From: Minkyu Kang @ 2010-10-25 8:11 UTC (permalink / raw)
To: u-boot
Dear Wolfgang Denk,
On 25 October 2010 13:19, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> This patch use card's tran_speed instead of hard setting value.
> I think mmc_set_clock(mmc, 52000000) is not good idea.
> because this is hard setting. we need use card's tran_speed.
>
> So If card_caps did't support High speed, we need set card's speed value
>
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
>
> ---
> ?drivers/mmc/mmc.c | ? ?9 +++++----
> ?1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index c543d83..f1b5552 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -815,11 +815,12 @@ int mmc_startup(struct mmc *mmc)
>
> ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS) {
> ? ? ? ? ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS_52MHz)
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 52000000);
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 52000000;
> ? ? ? ? ? ? ? ? ? ? ? ?else
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 26000000);
> - ? ? ? ? ? ? ? } else
> - ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 20000000);
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 26000000;
> + ? ? ? ? ? ? ? }
> +
> + ? ? ? ? ? ? ? mmc_set_clock(mmc, mmc->tran_speed);
> ? ? ? ?}
>
> ? ? ? ?/* fill in device description */
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
This patch has already been reviewed by Andy.
http://lists.denx.de/pipermail/u-boot/2010-May/071213.html
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] mmc: set tran_speed intead of hard setting
2010-10-25 8:11 ` Minkyu Kang
@ 2010-11-17 1:20 ` Minkyu Kang
0 siblings, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2010-11-17 1:20 UTC (permalink / raw)
To: u-boot
Dear Wolfgang and Andy,
On 25 October 2010 17:11, Minkyu Kang <promsoft@gmail.com> wrote:
> Dear Wolfgang Denk,
>
> On 25 October 2010 13:19, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> This patch use card's tran_speed instead of hard setting value.
>> I think mmc_set_clock(mmc, 52000000) is not good idea.
>> because this is hard setting. we need use card's tran_speed.
>>
>> So If card_caps did't support High speed, we need set card's speed value
>>
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>
>>
>> ---
>> ?drivers/mmc/mmc.c | ? ?9 +++++----
>> ?1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index c543d83..f1b5552 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -815,11 +815,12 @@ int mmc_startup(struct mmc *mmc)
>>
>> ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS) {
>> ? ? ? ? ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS_52MHz)
>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 52000000);
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 52000000;
>> ? ? ? ? ? ? ? ? ? ? ? ?else
>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 26000000);
>> - ? ? ? ? ? ? ? } else
>> - ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 20000000);
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 26000000;
>> + ? ? ? ? ? ? ? }
>> +
>> + ? ? ? ? ? ? ? mmc_set_clock(mmc, mmc->tran_speed);
>> ? ? ? ?}
>>
>> ? ? ? ?/* fill in device description */
Is it NAK? or pending?
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-17 1:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-25 4:19 [U-Boot] [PATCH] mmc: set tran_speed intead of hard setting Jaehoon Chung
2010-10-25 8:11 ` Minkyu Kang
2010-11-17 1:20 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox