* [U-Boot] [PATCH] ARM: use the same branch insn on all architectures
@ 2010-10-23 21:22 Wolfgang Denk
2010-10-25 6:10 ` Heiko Schocher
2010-10-26 19:19 ` Wolfgang Denk
0 siblings, 2 replies; 3+ messages in thread
From: Wolfgang Denk @ 2010-10-23 21:22 UTC (permalink / raw)
To: u-boot
For the "fixloop" implementation in start.S a number of different
instructions was used. Unify code so all architectures use "blo"
here because it is more robust in case of incorrect alignments.
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Albert ARIBAUD <albert.aribaud@free.fr>
Cc: Minkyu Kang <mk7.kang@samsung.com>
Cc: Sandeep Paulraj <s-paulraj@ti.com>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
---
arch/arm/cpu/arm1136/start.S | 2 +-
arch/arm/cpu/arm1176/start.S | 2 +-
arch/arm/cpu/arm720t/start.S | 2 +-
arch/arm/cpu/arm920t/start.S | 2 +-
arch/arm/cpu/arm925t/start.S | 2 +-
arch/arm/cpu/arm946es/start.S | 2 +-
arch/arm/cpu/arm_intcm/start.S | 2 +-
arch/arm/cpu/ixp/start.S | 2 +-
arch/arm/cpu/lh7a40x/start.S | 2 +-
arch/arm/cpu/s3c44b0/start.S | 2 +-
arch/arm/cpu/sa1100/start.S | 2 +-
11 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 29ed065..e30e398 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -262,7 +262,7 @@ fixnext:
str r1, [r0]
add r2, r2, #8 /* each rel.dyn entry is 8 bytes */
cmp r2, r3
- ble fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S
index 24e5bf4..8b2117b 100644
--- a/arch/arm/cpu/arm1176/start.S
+++ b/arch/arm/cpu/arm1176/start.S
@@ -305,7 +305,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S
index d93911f..1f52d58 100644
--- a/arch/arm/cpu/arm720t/start.S
+++ b/arch/arm/cpu/arm720t/start.S
@@ -222,7 +222,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/arm920t/start.S b/arch/arm/cpu/arm920t/start.S
index 343a760..af7cc59 100644
--- a/arch/arm/cpu/arm920t/start.S
+++ b/arch/arm/cpu/arm920t/start.S
@@ -267,7 +267,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/arm925t/start.S b/arch/arm/cpu/arm925t/start.S
index cf18a01..ef876e0 100644
--- a/arch/arm/cpu/arm925t/start.S
+++ b/arch/arm/cpu/arm925t/start.S
@@ -259,7 +259,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/arm946es/start.S b/arch/arm/cpu/arm946es/start.S
index 077886f..1bc5306 100644
--- a/arch/arm/cpu/arm946es/start.S
+++ b/arch/arm/cpu/arm946es/start.S
@@ -228,7 +228,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/arm_intcm/start.S b/arch/arm/cpu/arm_intcm/start.S
index 07356cb..5fc4a69 100644
--- a/arch/arm/cpu/arm_intcm/start.S
+++ b/arch/arm/cpu/arm_intcm/start.S
@@ -226,7 +226,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/ixp/start.S b/arch/arm/cpu/ixp/start.S
index 836c33b..4e169e2 100644
--- a/arch/arm/cpu/ixp/start.S
+++ b/arch/arm/cpu/ixp/start.S
@@ -351,7 +351,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/lh7a40x/start.S b/arch/arm/cpu/lh7a40x/start.S
index d944860..77c96bd 100644
--- a/arch/arm/cpu/lh7a40x/start.S
+++ b/arch/arm/cpu/lh7a40x/start.S
@@ -240,7 +240,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
diff --git a/arch/arm/cpu/s3c44b0/start.S b/arch/arm/cpu/s3c44b0/start.S
index 20091b2..21550fc 100644
--- a/arch/arm/cpu/s3c44b0/start.S
+++ b/arch/arm/cpu/s3c44b0/start.S
@@ -212,7 +212,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
/*
now copy to sram the interrupt vector
diff --git a/arch/arm/cpu/sa1100/start.S b/arch/arm/cpu/sa1100/start.S
index 8eabb66..6bb84c8 100644
--- a/arch/arm/cpu/sa1100/start.S
+++ b/arch/arm/cpu/sa1100/start.S
@@ -216,7 +216,7 @@ fixloop:
str r4, [r2]
add r2, r2, #4
cmp r2, r3
- bne fixloop
+ blo fixloop
#endif
#endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ARM: use the same branch insn on all architectures
2010-10-23 21:22 [U-Boot] [PATCH] ARM: use the same branch insn on all architectures Wolfgang Denk
@ 2010-10-25 6:10 ` Heiko Schocher
2010-10-26 19:19 ` Wolfgang Denk
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2010-10-25 6:10 UTC (permalink / raw)
To: u-boot
Hello Wolfgang,
Wolfgang Denk wrote:
> For the "fixloop" implementation in start.S a number of different
> instructions was used. Unify code so all architectures use "blo"
> here because it is more robust in case of incorrect alignments.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Albert ARIBAUD <albert.aribaud@free.fr>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Sandeep Paulraj <s-paulraj@ti.com>
> Cc: Prafulla Wadaskar <prafulla@marvell.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> ---
> arch/arm/cpu/arm1136/start.S | 2 +-
> arch/arm/cpu/arm1176/start.S | 2 +-
> arch/arm/cpu/arm720t/start.S | 2 +-
> arch/arm/cpu/arm920t/start.S | 2 +-
> arch/arm/cpu/arm925t/start.S | 2 +-
> arch/arm/cpu/arm946es/start.S | 2 +-
> arch/arm/cpu/arm_intcm/start.S | 2 +-
> arch/arm/cpu/ixp/start.S | 2 +-
> arch/arm/cpu/lh7a40x/start.S | 2 +-
> arch/arm/cpu/s3c44b0/start.S | 2 +-
> arch/arm/cpu/sa1100/start.S | 2 +-
> 11 files changed, 11 insertions(+), 11 deletions(-)
Acked-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ARM: use the same branch insn on all architectures
2010-10-23 21:22 [U-Boot] [PATCH] ARM: use the same branch insn on all architectures Wolfgang Denk
2010-10-25 6:10 ` Heiko Schocher
@ 2010-10-26 19:19 ` Wolfgang Denk
1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2010-10-26 19:19 UTC (permalink / raw)
To: u-boot
In message <1287868958-29447-1-git-send-email-wd@denx.de> you wrote:
> For the "fixloop" implementation in start.S a number of different
> instructions was used. Unify code so all architectures use "blo"
> here because it is more robust in case of incorrect alignments.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Albert ARIBAUD <albert.aribaud@free.fr>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Sandeep Paulraj <s-paulraj@ti.com>
> Cc: Prafulla Wadaskar <prafulla@marvell.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> ---
> arch/arm/cpu/arm1136/start.S | 2 +-
> arch/arm/cpu/arm1176/start.S | 2 +-
> arch/arm/cpu/arm720t/start.S | 2 +-
> arch/arm/cpu/arm920t/start.S | 2 +-
> arch/arm/cpu/arm925t/start.S | 2 +-
> arch/arm/cpu/arm946es/start.S | 2 +-
> arch/arm/cpu/arm_intcm/start.S | 2 +-
> arch/arm/cpu/ixp/start.S | 2 +-
> arch/arm/cpu/lh7a40x/start.S | 2 +-
> arch/arm/cpu/s3c44b0/start.S | 2 +-
> arch/arm/cpu/sa1100/start.S | 2 +-
> 11 files changed, 11 insertions(+), 11 deletions(-)
Applied.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
- R. Pirsig, "Zen and the Art of Motorcycle Maintenance"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-26 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-23 21:22 [U-Boot] [PATCH] ARM: use the same branch insn on all architectures Wolfgang Denk
2010-10-25 6:10 ` Heiko Schocher
2010-10-26 19:19 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox