From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Wed, 27 Oct 2010 08:26:48 +0200
Subject: [U-Boot] arm, omap3, beagle: initial stack pointer setup
Message-ID: <4CC7C628.70402@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Steve,

today morning I tried actual u-boot on the beagle board, and I couldn;t
compile it because a problem with the GENERATED_GBL_DATA_SIZE changes.

In this context the question raised, if the

#define CONFIG_SYS_INIT_SP_ADDR         (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)

setup with using LOW_LEVEL_SRAM_STACK @ 0x4020FFFC is OK?

The address
a) it is not aligned
b) We should use CONFIG_SYS_INIT_RAM_SIZE and CONFIG_SYS_INIT_RAM_ADDR

So my question:

shouldn;t we add in "arch/arm/include/asm/arch-omap3/omap3.h" or
"include/asm/arch/cpu.h"? this 2 missing defines (described in b)),
and change in all omap3 plattforms

#define CONFIG_SYS_INIT_SP_ADDR         (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)

to

#define CONFIG_SYS_INIT_SP_ADDR	(CONFIG_SYS_INIT_RAM_ADDR + \
				CONFIG_SYS_INIT_RAM_SIZE - \
				GENERATED_GBL_DATA_SIZE)

With

CONFIG_SYS_INIT_RAM_ADDR	(SRAM_VECT_CODE)
                                 ^
                                 0x4020f800
CONFIG_SYS_INIT_RAM_SIZE	0x7f0

What do you think?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany