public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] make-asm-offsets: fix sed script
Date: Wed, 27 Oct 2010 08:54:41 +0200	[thread overview]
Message-ID: <4CC7CCB1.3080001@denx.de> (raw)
In-Reply-To: <1288161467-2979-1-git-send-email-wd@denx.de>

Hello Wolfgang,

Wolfgang Denk wrote:
> When copying the "sed" script to generate the asm-offsets.h file from
> the Linux Kbuild script into the make-asm-offsets file I missed the
> fact that the former runs in a "make" context and thus uses double
> "$$" to escape a single "$", while the latter is a shell script, where
> this must not be done.  Unfortunately the problem did not show up
> during the initial tests on Power Architecture systems, but on ARM the
> generated asm-offsets.h was not correct.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
>  tools/scripts/make-asm-offsets |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Tested on the omap3_beagle board, so:

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2010-10-27  6:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27  6:37 [U-Boot] [PATCH] make-asm-offsets: fix sed script Wolfgang Denk
2010-10-27  6:54 ` Heiko Schocher [this message]
2010-10-27 14:45 ` Ben Gardiner
2010-10-27 18:17 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC7CCB1.3080001@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox