public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] imx: Get fec mac address from fuse
Date: Wed, 27 Oct 2010 10:49:31 +0200	[thread overview]
Message-ID: <4CC7E79B.70805@denx.de> (raw)
In-Reply-To: <AANLkTinSzdDYSkPM6VX1xX-Pp_pWr2gA5H0p=iELcfgR@mail.gmail.com>

On 10/27/2010 09:40 AM, Jason Liu wrote:

> Yes, I haved looked it before and I also tested this patch on
> MX51babbage 3.0 board. It will printting some confusing information
> with floating value of MAC address when the board boot up after you
> set the ethaddr enviorment. The reason is that, when it first call
> fec_init, the eth address of dev is not intialized and then it using
> the floating memory value.

Dropping the call is not the solution and works only on the MX51 if the
MAC is set into the fuse. Even on the MX51, this is not a general case:
it should be always possible to set the ethaddr via the environment
without using the fuse.

As sure, you should at least see a "Warning : MAC addresses don't match"
if the ethaddr is set to a different value as in the fuse.

However, I do not yet understand why the address is not set: fec_probe
is called before doing something on the network and at this point the
address should be set from fuse.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2010-10-27  8:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22 11:25 [U-Boot] [PATCH 1/2] imx: Get fec mac address from fuse Jason Liu
2010-10-22 11:25 ` [U-Boot] [PATCH 2/2] MX5: board version not printed corretly on MX51EVK Jason Liu
2010-10-26  7:53   ` Stefano Babic
2010-10-26 10:29     ` Jason Liu
2010-10-27  7:22       ` Stefano Babic
2010-10-26  7:45 ` [U-Boot] [PATCH 1/2] imx: Get fec mac address from fuse Stefano Babic
2010-10-26 10:35   ` Jason Liu
2010-10-27  7:21     ` Stefano Babic
2010-10-27  7:40       ` Jason Liu
2010-10-27  8:49         ` Stefano Babic [this message]
2010-10-27  9:21           ` Jason Liu
2010-10-27 17:50             ` John Rigby
2010-10-27 18:06               ` Wolfgang Denk
2010-10-27 18:59                 ` John Rigby
  -- strict thread matches above, loose matches on Subject: below --
2010-10-25 13:07 Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC7E79B.70805@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox