* [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE
@ 2010-10-27 14:07 Steve Sakoman
2010-10-27 14:34 ` Heiko Schocher
0 siblings, 1 reply; 7+ messages in thread
From: Steve Sakoman @ 2010-10-27 14:07 UTC (permalink / raw)
To: u-boot
This patch fixes the issue by defining and using CONFIG_SYS_INIT_RAM_SIZE and
CONFIG_SYS_INIT_RAM_ADDR. Based on an email discussion with Wolfgang Denk and
Heiko Schocher.
Signed-off-by: Steve Sakoman <steve.sakoman@linaro.org>
---
Tested on Overo. Will test on all available boards later today.
diff --git a/include/configs/igep0020.h b/include/configs/igep0020.h
index 16d9279..a970ad2 100644
--- a/include/configs/igep0020.h
+++ b/include/configs/igep0020.h
@@ -222,6 +222,10 @@
#endif /* (CONFIG_CMD_NET) */
#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
-#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800
+#define CONFIG_SYS_INIT_RAM_SIZE 0x800
+#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
+ CONFIG_SYS_INIT_RAM_SIZE - \
+ GENERATED_GBL_DATA_SIZE)
#endif /* __CONFIG_H */
diff --git a/include/configs/igep0030.h b/include/configs/igep0030.h
index d6fbec7..031de35 100644
--- a/include/configs/igep0030.h
+++ b/include/configs/igep0030.h
@@ -209,6 +209,10 @@
#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10))
#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
-#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800
+#define CONFIG_SYS_INIT_RAM_SIZE 0x800
+#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
+ CONFIG_SYS_INIT_RAM_SIZE - \
+ GENERATED_GBL_DATA_SIZE)
#endif /* __CONFIG_H */
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index e7d5bd0..076dd5a 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -346,8 +346,11 @@ extern unsigned int boot_flash_sec;
extern unsigned int boot_flash_type;
#endif
-/* additions for new relocation code, must be added to all boards */
#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
-#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800
+#define CONFIG_SYS_INIT_RAM_SIZE 0x800
+#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
+ CONFIG_SYS_INIT_RAM_SIZE - \
+ GENERATED_GBL_DATA_SIZE)
#endif /* __CONFIG_H */
diff --git a/include/configs/omap3_overo.h b/include/configs/omap3_overo.h
index 052d503..79a5b85 100644
--- a/include/configs/omap3_overo.h
+++ b/include/configs/omap3_overo.h
@@ -325,6 +325,10 @@ extern unsigned int boot_flash_type;
#endif /* (CONFIG_CMD_NET) */
#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
-#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800
+#define CONFIG_SYS_INIT_RAM_SIZE 0x800
+#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
+ CONFIG_SYS_INIT_RAM_SIZE - \
+ GENERATED_GBL_DATA_SIZE)
#endif /* __CONFIG_H */
diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h
index 9dda2a3..76131fd 100644
--- a/include/configs/omap4_panda.h
+++ b/include/configs/omap4_panda.h
@@ -227,6 +227,10 @@
#define CONFIG_NR_DRAM_BANKS 1
#define CONFIG_SYS_SDRAM_BASE 0x80000000
-#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_RAM_ADDR 0x4030E000
+#define CONFIG_SYS_INIT_RAM_SIZE 0x800
+#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
+ CONFIG_SYS_INIT_RAM_SIZE - \
+ GENERATED_GBL_DATA_SIZE)
#endif /* __CONFIG_H */
diff --git a/include/configs/omap4_sdp4430.h b/include/configs/omap4_sdp4430.h
index 36471ba..3d4d3a7 100644
--- a/include/configs/omap4_sdp4430.h
+++ b/include/configs/omap4_sdp4430.h
@@ -245,6 +245,10 @@
#define CONFIG_NR_DRAM_BANKS 1
#define CONFIG_SYS_SDRAM_BASE 0x80000000
-#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_RAM_ADDR 0x4030E000
+#define CONFIG_SYS_INIT_RAM_SIZE 0x800
+#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
+ CONFIG_SYS_INIT_RAM_SIZE - \
+ GENERATED_GBL_DATA_SIZE)
#endif /* __CONFIG_H */
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE
2010-10-27 14:07 [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE Steve Sakoman
@ 2010-10-27 14:34 ` Heiko Schocher
2010-10-27 14:56 ` Paulraj, Sandeep
0 siblings, 1 reply; 7+ messages in thread
From: Heiko Schocher @ 2010-10-27 14:34 UTC (permalink / raw)
To: u-boot
Hello Steve,
Steve Sakoman wrote:
> This patch fixes the issue by defining and using CONFIG_SYS_INIT_RAM_SIZE and
> CONFIG_SYS_INIT_RAM_ADDR. Based on an email discussion with Wolfgang Denk and
> Heiko Schocher.
>
> Signed-off-by: Steve Sakoman <steve.sakoman@linaro.org>
> ---
>
> Tested on Overo. Will test on all available boards later today.
Test this patch on my beagle board, works fine:
Tested-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE
2010-10-27 14:34 ` Heiko Schocher
@ 2010-10-27 14:56 ` Paulraj, Sandeep
2010-10-27 15:11 ` Wolfgang Denk
0 siblings, 1 reply; 7+ messages in thread
From: Paulraj, Sandeep @ 2010-10-27 14:56 UTC (permalink / raw)
To: u-boot
>
> Hello Steve,
>
> Steve Sakoman wrote:
> > This patch fixes the issue by defining and using
> CONFIG_SYS_INIT_RAM_SIZE and
> > CONFIG_SYS_INIT_RAM_ADDR. Based on an email discussion with Wolfgang
> Denk and
> > Heiko Schocher.
> >
> > Signed-off-by: Steve Sakoman <steve.sakoman@linaro.org>
> > ---
> >
> > Tested on Overo. Will test on all available boards later today.
>
> Test this patch on my beagle board, works fine:
>
> Tested-by: Heiko Schocher <hs@denx.de>
>
Should I consider this a bug fix and add it to my tree?
I believe the patch itself came after the merge window ended
Thanks,
Sandeep
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE
2010-10-27 14:56 ` Paulraj, Sandeep
@ 2010-10-27 15:11 ` Wolfgang Denk
2010-10-27 17:12 ` Steve Sakoman
0 siblings, 1 reply; 7+ messages in thread
From: Wolfgang Denk @ 2010-10-27 15:11 UTC (permalink / raw)
To: u-boot
Dear "Paulraj, Sandeep",
In message <0554BEF07D437848AF01B9C9B5F0BC5DA9D898CE@dlee01.ent.ti.com> you wrote:
>
> > Test this patch on my beagle board, works fine:
> >
> > Tested-by: Heiko Schocher <hs@denx.de>
> >
>
> Should I consider this a bug fix and add it to my tree?
>
> I believe the patch itself came after the merge window ended
Yes, all these are bug fixes needed to get the current code working
as expected. Please apply. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A great many people think they are thinking when they are merely re-
arranging their prejudices." - William James
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE
2010-10-27 15:11 ` Wolfgang Denk
@ 2010-10-27 17:12 ` Steve Sakoman
2010-10-27 17:32 ` Paulraj, Sandeep
0 siblings, 1 reply; 7+ messages in thread
From: Steve Sakoman @ 2010-10-27 17:12 UTC (permalink / raw)
To: u-boot
On Wed, 2010-10-27 at 17:11 +0200, Wolfgang Denk wrote:
> Dear "Paulraj, Sandeep",
>
> In message <0554BEF07D437848AF01B9C9B5F0BC5DA9D898CE@dlee01.ent.ti.com> you wrote:
> >
> > > Test this patch on my beagle board, works fine:
> > >
> > > Tested-by: Heiko Schocher <hs@denx.de>
> > >
> >
> > Should I consider this a bug fix and add it to my tree?
> >
> > I believe the patch itself came after the merge window ended
>
> Yes, all these are bug fixes needed to get the current code working
> as expected. Please apply. Thanks.
Sandeep, there are a couple of other pending patches that are build
fixers:
ARMV7: OMAP3: IGEP: Rename TEXT_BASE
ARMV7: Fix build for non-OMAP3 boards
They've been posted to the list for a few days now, and are also sitting
in my omap4-next-upstream branch.
Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE
2010-10-27 17:12 ` Steve Sakoman
@ 2010-10-27 17:32 ` Paulraj, Sandeep
2010-11-02 14:44 ` Steve Sakoman
0 siblings, 1 reply; 7+ messages in thread
From: Paulraj, Sandeep @ 2010-10-27 17:32 UTC (permalink / raw)
To: u-boot
>
> On Wed, 2010-10-27 at 17:11 +0200, Wolfgang Denk wrote:
> > Dear "Paulraj, Sandeep",
> >
> > In message <0554BEF07D437848AF01B9C9B5F0BC5DA9D898CE@dlee01.ent.ti.com>
> you wrote:
> > >
> > > > Test this patch on my beagle board, works fine:
> > > >
> > > > Tested-by: Heiko Schocher <hs@denx.de>
> > > >
> > >
> > > Should I consider this a bug fix and add it to my tree?
> > >
> > > I believe the patch itself came after the merge window ended
> >
> > Yes, all these are bug fixes needed to get the current code working
> > as expected. Please apply. Thanks.
>
> Sandeep, there are a couple of other pending patches that are build
> fixers:
>
> ARMV7: OMAP3: IGEP: Rename TEXT_BASE
> ARMV7: Fix build for non-OMAP3 boards
>
> They've been posted to the list for a few days now, and are also sitting
> in my omap4-next-upstream branch.
>
> Steve
>
Yes I have seen them. Pull request will be sent on Saturday or Sunday.
Sandeep
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE
2010-10-27 17:32 ` Paulraj, Sandeep
@ 2010-11-02 14:44 ` Steve Sakoman
0 siblings, 0 replies; 7+ messages in thread
From: Steve Sakoman @ 2010-11-02 14:44 UTC (permalink / raw)
To: u-boot
On Wed, Oct 27, 2010 at 10:32 AM, Paulraj, Sandeep <s-paulraj@ti.com> wrote:
>
>
>>
>> On Wed, 2010-10-27 at 17:11 +0200, Wolfgang Denk wrote:
>> > Dear "Paulraj, Sandeep",
>> >
>> > In message <0554BEF07D437848AF01B9C9B5F0BC5DA9D898CE@dlee01.ent.ti.com>
>> you wrote:
>> > >
>> > > > Test this patch on my beagle board, works fine:
>> > > >
>> > > > Tested-by: Heiko Schocher <hs@denx.de>
>> > > >
>> > >
>> > > Should I consider this a bug fix and add it to my tree?
>> > >
>> > > I believe the patch itself came after the merge window ended
>> >
>> > Yes, all these are bug fixes needed to get the current code working
>> > as expected. ?Please apply. ?Thanks.
>>
>> Sandeep, there are a couple of other pending patches that are build
>> fixers:
>>
>> ARMV7: OMAP3: IGEP: Rename TEXT_BASE
>> ARMV7: Fix build for non-OMAP3 boards
>>
>> They've been posted to the list for a few days now, and are also sitting
>> in my omap4-next-upstream branch.
>>
>> Steve
>>
>
> Yes I have seen them. Pull request will be sent on Saturday or Sunday.
Any update on this? It would be good to get mainline in a build-able
state again.
Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-11-02 14:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-27 14:07 [U-Boot] [PATCH RFC] ARMV7: OMAP: Fix build after introduction of GENERATED_GBL_DATA_SIZE Steve Sakoman
2010-10-27 14:34 ` Heiko Schocher
2010-10-27 14:56 ` Paulraj, Sandeep
2010-10-27 15:11 ` Wolfgang Denk
2010-10-27 17:12 ` Steve Sakoman
2010-10-27 17:32 ` Paulraj, Sandeep
2010-11-02 14:44 ` Steve Sakoman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox