U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] da850evm: remove GENERATED_GBL_DATA_SIZE from initial stack
Date: Wed, 27 Oct 2010 16:35:47 +0200	[thread overview]
Message-ID: <4CC838C3.7090105@denx.de> (raw)
In-Reply-To: <1288189635-15414-1-git-send-email-bengardiner@nanometrics.ca>

Hello Ben,

Ben Gardiner wrote:
> Commit 25ddd1fb0a2281b182529afbc8fda5de2dc16d96 broke the da850evm build. The
> introduction of GENERATED_GBL_DATA_SIZE led to:
> 
> $make mrproper ; make da850evm_config ; make -j9 all|grep -E '( error| warning)'
> Generating include/autoconf.mk
> Generating include/autoconf.mk.dep
> awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend
> Configuring for da850evm board...
> start.S: Assembler messages:
> start.S:177: Error: missing ')'
> start.S:177: Error: missing ')'
> start.S:177: Error: garbage following instruction -- `ldr sp,=((0xc0000000+0x1000-#96))'
> make[1]: *** [start.o] Error 1
> make: *** [arch/arm/cpu/arm926ejs/start.o] Error 2
> make: *** Waiting for unfinished jobs....
> 
> This patch removes from the definition of CONFIG_SYS_INIT_SP_ADDR the
> GENERATED_GBL_DATA_SIZE offset -- it doesn't appear to be needed since the
> resulting u-boot works fine; tested with NAND, env.oob and tftp.

Not necessary, already fixed here:

http://lists.denx.de/pipermail/u-boot/2010-October/080455.html

Can you try instead this patch?

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2010-10-27 14:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 14:27 [U-Boot] [PATCH] da850evm: remove GENERATED_GBL_DATA_SIZE from initial stack Ben Gardiner
2010-10-27 14:35 ` Heiko Schocher [this message]
2010-10-27 14:42   ` Ben Gardiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC838C3.7090105@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox