From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] imx25: Fix reset
Date: Wed, 27 Oct 2010 16:43:46 +0200 [thread overview]
Message-ID: <4CC83AA2.2070900@emk-elektronik.de> (raw)
In-Reply-To: <1288190078-2770-1-git-send-email-weisserm@arcor.de>
Dear Matthias Weisser,
> struct wdog_regs {
> - u32 wcr; /* Control */
> - u32 wsr; /* Service */
> - u32 wrsr; /* Reset Status */
> - u32 wicr; /* Interrupt Control */
> - u32 wmcr; /* Misc Control */
> + u16 wcr; /* Control */
> + u16 wsr; /* Service */
> + u16 wrsr; /* Reset Status */
> + u16 wicr; /* Interrupt Control */
> + u16 wmcr; /* Misc Control */
> };
What catches my ARM-aware eye:
I do not know the hardware, but are those registers really
arranged on 2 byte boundaries (00, 02, 04, 06, 08, 0a, .. offsets)?
Probably yes, assuming your code is tested ;)
Or should there be a u16 filler between each register?
Best Regards,
Reinhard
next prev parent reply other threads:[~2010-10-27 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 14:34 [U-Boot] [PATCH V3] imx25: Fix reset Matthias Weisser
2010-10-27 14:43 ` Reinhard Meyer [this message]
2010-10-27 15:29 ` Stefano Babic
2010-10-27 15:33 ` Matthias Weißer
2010-10-28 11:18 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC83AA2.2070900@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox