From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_sf: remove warning introduced with last patch
Date: Fri, 29 Oct 2010 11:14:48 +0200 [thread overview]
Message-ID: <4CCA9088.1090108@denx.de> (raw)
In-Reply-To: <AANLkTik+hwCO9HPoRTQJR=vsCaAjCUOE2+VDNYzrh40C@mail.gmail.com>
On 10/28/2010 07:47 PM, Mike Frysinger wrote:
> if you're going to start at 1, shouldnt you then drop the redundant
> assignment to 1 ?
> if (!saved_buffer) {
> ret = 1;
> goto done;
> }
> -mike
>
Yes, it is redundant - I'll drop it.
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2010-10-29 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 10:39 [U-Boot] [PATCH] env_sf: remove warning introduced with last patch Stefano Babic
2010-10-28 17:47 ` Mike Frysinger
2010-10-29 9:14 ` Stefano Babic [this message]
2010-10-29 9:49 ` [U-Boot] [PATCH V2] " Stefano Babic
2010-10-29 21:08 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCA9088.1090108@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox