From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Fri, 29 Oct 2010 11:14:48 +0200
Subject: [U-Boot] [PATCH] env_sf: remove warning introduced with last
	patch
In-Reply-To: <AANLkTik+hwCO9HPoRTQJR=vsCaAjCUOE2+VDNYzrh40C@mail.gmail.com>
References: <1288262391-22518-1-git-send-email-sbabic@denx.de>
	<AANLkTik+hwCO9HPoRTQJR=vsCaAjCUOE2+VDNYzrh40C@mail.gmail.com>
Message-ID: <4CCA9088.1090108@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/28/2010 07:47 PM, Mike Frysinger wrote:

> if you're going to start at 1, shouldnt you then drop the redundant
> assignment to 1 ?
>         if (!saved_buffer) {
>             ret = 1;
>             goto done;
>         }
> -mike
> 

Yes, it is redundant - I'll drop it.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================