[U-Boot] CONFIG_SKIP_RELOCATE_UBOOT still used?

Albert ARIBAUD
2010-10-29T09:32:51Z

Le 28/10/2010 13:46, Alexander Holler a ?crit :
> Am 28.10.2010 13:16, schrieb Reinhard Meyer:
>>> CONFIG_SKIP_RELOCATE_UBOOT
>>
>> The old way in ARM before ELF relocation was introduced. A misnomer because it seemingly
>> skipped the *COPY* of the image from whereever it was loaded to the TEXT_BASE
>> location. There was no real *RELOCATION* done there. This define probably does not work
>> anymore. It was set on ARM boards where a preloader did load u-boot to the
>> TEXT_BASE address.
>>
>> In an up to date ARM system all those defines MUST NOT be set.
>
> Thanks for that explanation.
>
> In regard to CONFIG_SKIP_RELOCATE_UBOOT I've hit a typo in
> arch/arm/cpu/arm926ejs/start.S while trying to use this define to build
> a non relocatable u-boot. In line 383 there is
>
> ldr pc, r0
>
> which seems to should be
>
> ldr pc, [r0]

I don't think it should. r0 is computed to be the address at which to
branch, so the branch there is direct, not indirect. That could be
changed to "mov pc, r0" for clarity, though.

Amicalement,
--
Albert.