From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reinhard Meyer Date: Mon, 01 Nov 2010 13:31:38 +0100 Subject: [U-Boot] [PATCH 06/11] at91: Add defines for spi SoC access In-Reply-To: <20101101093636.A56C81522C0@gemini.denx.de> References: <1288600195-6960-1-git-send-email-alexander.stein@systec-electronic.com> <1288600195-6960-7-git-send-email-alexander.stein@systec-electronic.com> <4CCE7DCD.6090004@emk-elektronik.de> <20101101093636.A56C81522C0@gemini.denx.de> Message-ID: <4CCEB32A.6080407@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, > Dear Reinhard Meyer, > > In message<4CCE7DCD.6090004@emk-elektronik.de> you wrote: >> >> If we touch header and driver anyway, we could get rid of the depreciated typedefs, >> to get conform to the coding style. > > I recommend NOT doing this, at least not as part of this patch series. > > If a clean-up is intended, it should be done in a strictly separate set > of patches (either before or after the current series). In this particular case the driver is not yet using the (existing) struct at91_spi at all.... WAIT....!!! There is the COMMON driver atmel_spi.c with atmel_spi.h in drivers/spi. There need not be and should not be an at91_spi.h; or do I miss something here? Best Regards, Reinhard