From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gray Remlin Date: Tue, 02 Nov 2010 00:31:50 +0000 Subject: [U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted In-Reply-To: <20101101190631.D5B191524F4@gemini.denx.de> References: <1288267776-1148-1-git-send-email-sr@denx.de> <20101029210612.BB8D6152451@gemini.denx.de> <201011011420.35851.sr@denx.de> <20101101190631.D5B191524F4@gemini.denx.de> Message-ID: <4CCF5BF6.2070806@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/11/10 19:06, Wolfgang Denk wrote: > Dear Stefan Roese, > > In message <201011011420.35851.sr@denx.de> you wrote: >> >>>> Only allow (re-)assignment to an UBI partition/device when UBIFS is >>>> currently not mounted. Otherwise the following UBIFS commands will >>>> crash. >>>> >>>> Signed-off-by: Stefan Roese >>>> --- >>>> >>>> common/cmd_ubi.c | 13 +++++++++++++ >>>> common/cmd_ubifs.c | 5 +++++ >>>> 2 files changed, 18 insertions(+), 0 deletions(-) >>> >>> I'm a bit biased here - from standard Unix command usage it seems >>> natural that you have to manually umount first, but then we have very >>> smple device handling in U-Boot, with always only one device in >>> access. Would it not make sense to auto-unmount in case the user >>> switches the device? >> >> I can implement it this way if preferred. I'll prepare a new for this later. > > As mentioned - I am not sure what would be best here. > > What is your own position? > > And: anybody else to comment? > > Best regards, > > Wolfgang Denk > As a 'User' what matters the most to me is command user interface consistency (yes I want the impossible) regardless of the filesystem\device type. For example to load uImage, I want 'load ::' whether it be an ide device with ext3 filesystem or a mmc device with ubifs. If a filesystem needs to be mounted for some devices\commands but not others then it should 'just happen' when needed. As a 'User' my only interest is the desired end result with the minimum of brainpower input. I want all related commands to take the same arguments in the same order. I want to be able to use them without understanding (technically) what they do. An acceptable alternative would be to 'select :' then have all further commands refer to said ':' without restating. But I would want all commands to work that way. And personally, I like terse commands, but I know others hate them....Oh well. As a developer I know this is unrealistic...but a 'User' what matters the most to me is command user interface consistency!