From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Tue, 02 Nov 2010 08:05:40 +0100
Subject: [U-Boot] [PATCH 2/2] Add video support to mx51evk board
In-Reply-To: <6D46366820216241BB9459D07B269372D2B75A@039-SN1MPN1-002.039d.mgd.msft.net>
References: <6D46366820216241BB9459D07B269372D2B75A@039-SN1MPN1-002.039d.mgd.msft.net>
Message-ID: <4CCFB844.5030405@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/02/2010 06:16 AM, Frias Renato-B13784 wrote:
> Adds video support to mx51evk board, this board allows different displays.
> This patch enables the WVGA TFT LCD panel only, remove comments from
> include/configs/mx51evk.h to use it.

This patch is corrupted as the first one by your mailer.

> +#ifdef CONFIG_LCD
> +static struct fb_videomode claa_wvga = {
> +       "CLAA07LC0ACW",
> +       57,     /* Refresh */+
> +       800,    /* xres */
> +       480,    /* yres */
> +       37037,  /* pixclock = 27Mhz */
> +       40,     /* left margin */
> +       60,     /* right margin */
> +       10,     /* upper margin */
> +       10,     /* lower margin */
> +       20,     /* hsync-len */
> +       10,     /* vsync-len */
> +       0,      /* sync */
> +       FB_VMODE_NONINTERLACED, /* vmode */
> +       0,      /* flag */
> +};

It seems you start with trailing whitespaces instead of tabs

> +#ifdef CONFIG_LCD
> +void setup_iomux_ipu(void)
> +{
> +       /* DISP2_DAT [0:15] are configured by default */
> +       mxc_request_iomux(MX51_PIN_DI1_D1_CS, IOMUX_CONFIG_ALT4);
> +       mxc_iomux_set_pad(MX51_PIN_DI1_D1_CS, 0x85);

With the vision2 I introduced constants to set pads (PAD_CTL_*). At
least for new values, you should use it.

> +       /* DISP2_DRDY pin */
> +       mxc_request_iomux(MX51_PIN_DI_GP4, IOMUX_CONFIG_ALT4);
> +       mxc_iomux_set_pad(MX51_PIN_DI_GP4, 0x80);

Ditto

> diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
> index f98438d..cd931ea 100644
> --- a/include/configs/mx51evk.h
> +++ b/include/configs/mx51evk.h
> @@ -211,6 +211,17 @@
>  #define CONFIG_SYS_DDR_CLKSEL  0
>  #define CONFIG_SYS_CLKTL_CBCDR 0x59E35100
> 
> +/*
> + * Framebuffer and LCD
> + */
> +/*

Are the new defines inside a comment ?

> +#define CONFIG_LCD
> +#define CONFIG_VIDEO_MX5
> +#define LCD_BPP                LCD_COLOR16
> +#define CONFIG_CMD_BMP
> +#define CONFIG_BMP_16BPP
> +*/

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================