From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Add video support for mx51evk
Date: Tue, 02 Nov 2010 09:59:39 +0100 [thread overview]
Message-ID: <4CCFD2FB.6060000@denx.de> (raw)
In-Reply-To: <20101102083526.685BE1524F4@gemini.denx.de>
On 11/02/2010 09:35 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
>
> In message <4CCFB244.2000909@denx.de> you wrote:
>>
>> Consider this, I do not think the actual computation in lcd_setmem() is
>> correct. We need to compute the maximum amount of memory to be reserved
>> to the framebuffer, not the value requested by the current display
>> interface. We could add a CONFIG_SYS_VIDEO_SIZE that contains the
>> maximum amount of memory needed, because the value is strictly
>> board-dependent, and change lcd_setmem to use it. Anatolij, what do you
>> think about this ?
>
> Why cannot you determine the exact amount needed at runtime?
Agree, we can do it, and it is better - I do not think we need really to
change dinamically (I mean, in the same u-boot session) the LCD
connected to the framebuffer, reason that requires to reserve the
maximum amount of memory.
We could introduce a weak function, that a board maintainer can decide
to implement or not. This maintains the compatibility with the most
drivers where vpanel is static initialized.
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2010-11-02 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 5:29 [U-Boot] Add video support for mx51evk Frias Renato-B13784
2010-11-02 6:40 ` Stefano Babic
2010-11-02 8:35 ` Wolfgang Denk
2010-11-02 8:59 ` Stefano Babic [this message]
2010-11-02 9:42 ` Wolfgang Denk
2010-11-02 9:49 ` Stefano Babic
2010-11-02 13:34 ` Wolfgang Denk
2010-11-02 16:01 ` Stefano Babic
2010-11-02 19:41 ` Wolfgang Denk
2010-11-02 9:18 ` Anatolij Gustschin
2010-11-03 0:04 ` Renato Frias
-- strict thread matches above, loose matches on Subject: below --
2010-11-02 5:15 Frias Renato-B13784
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCFD2FB.6060000@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox